[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH v7 00/51] xen: Build system improvements, now with out-of-tree build!


  • To: Alex Bennée <alex.bennee@xxxxxxxxxx>
  • From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Date: Thu, 4 Nov 2021 16:34:41 +0000
  • Authentication-results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, "Tim Deegan" <tim@xxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Tamas K Lengyel <tamas@xxxxxxxxxxxxx>, Doug Goldstein <cardoe@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, "Julien Grall" <julien@xxxxxxx>, Alexandru Isaila <aisaila@xxxxxxxxxxxxxxx>, "Stefano Stabellini" <sstabellini@xxxxxxxxxx>, Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>, Petre Pircalabu <ppircalabu@xxxxxxxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Lukasz Hawrylko <lukasz.hawrylko@xxxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Thu, 04 Nov 2021 16:34:59 +0000
  • Ironport-data: A9a23:az+to6mEGKpheC+s68wW0zLo5gykI0RdPkR7XQ2eYbSJt1+Wr1Gzt xIWUDqPPf/YZzSnf9p0YYvn8kgEucPdy99mHQtkqn80QiMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA187IMsdoUg7wbdg29Y02YLR7z6l4 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4 PZN6aeBRTt2ApKWlsZMUhl2Mwt9I7ITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq 6ZecmpUKEne2aTmm9pXScE17ignBMDtIIMYvGAm1TzDBOwqaZvCX7/L9ZlT2zJYasVmQKiAP JJINGUHgBLoOxl2JAsbFY0EkvqJ20D1NBxWmQOZnP9ii4TU5FMoi+W8WDbPQfSWRMB9jkue4 GXc8AzRCxUbL8CWyCDD/GilgOTOhgvkVIlUH7q9ntZonVvVwGUQAR8XUFKToP+lh0r4UNVaQ 2Qf8zAiqqUa/0WxQt7wGRa/pRasohcZUsF4D+4+5QeC26fQpQ2eAwAsRDlLYs0rr88ySDkj0 HeGmtroAXpkt7j9YXCX+6qQrDiyETMINmJEbigBJSMV7t+mrIwtgxbnStd4DLXzntDzASv3w T2BsG45nbp7pc0GyaS9u0zGijSEp57VQwpz7QLSNkqu6QV/Y4ypbpKp8nDU6P9BKMCSSVzpl HkbmeCO4eYWF5aPmSeRBuIXE9mB5PGDKjTQx0FuG5oJ8C6k8HquO4tX5VlWKF9yN8cYeRfge ELJpR5K/5hXIWeraqlsJYm2DqwCwafsGNv/X9jIf9FOZd53bwbB8yZwDWau2GTqnFkpgLsIE 56ResaxDl4XEa1iijGxQo812Lsm1mY0yGXVSJ3TyxWh2KCZInmPRt8tL1+mfu0/qqSer2396 99CM+OaxhMZV/fxCgHV7IoSIFYiPXU9Q5fspKR/cvOAKxF0XmEoFOXAxbAmU4hkmblF0ObO4 ny5HERfzTLXjHzcIASOY1hpaa/jUJhyq342J2onOlPA82A7YJyk5aMWfYYfd7g7+OFtwPh4Q uNDcMKFatxUUSjO8TkZaZj7raRheQ6tiAbIODCqCAXTZLY5GVaPoIW9OFKyqm9eVUJbqPfSv ZWD1l/gcJY/GDhdVsj0OfOv4XObvmYCzbcas1TzHvFff0Dl8Y5PIiP3j+MqL8xkFSgv1gd2x C7NX05G+LClT5sdtYCQ2Pva99vB//5WRxICRwHmAaCK2T42F4ZJ6atJS662cD/UTwsYE43yN LwOn5kQ3BDq9WumUraQ8Z43ksrSBPO1/te2KziI+l2RPzxH7Zs6cxG7MTFn7PEl+1OjhSO4W 1iU5v5RMqiTNcXuHTY5fVR+M7XdiKlNymOKvJzZxXkWAgctrNJrtm0IbnGxZNF1duMpYOvJP 8944Kb6FDBTejJ1a43b30i4BkyHL2AaUrVPi33pKNSDt+bf8XkbOca0InavuPmnMowQWmF3c m78rPeT3Nx0mxudG0ff4FCQhIJ1n4oVghlWwTcqfhLR8jYzrqRsh0M5HPVeZlk98yirJMopZ TQ7aRYofPrTl9qq7eAaN12R98h6LEXx0iTMJ5EhzgU1lmGkCT7AKnMTI+GI8BxL+m5QZGEDr rqZ1HzkQXDhe8Sohnk+XktsqvrCS91t91KdxJD7TprdR5RqMyD4hqKOZHYTr0e1C80Gm0Ca9 /Jh+/x9aPOnOHdI8bE7EYSTyZ8ZVAuAeD5ZWfhk8a5QRTPcdTi+1CKgMUe0fs8RdfXG/VXhU 55lJ95VVgT43yGL92hJCakJKr5yvfgo+NtdJe+7eT9Y6+OS92M7vojR+y7ygH4Qb+9vyctte JnMcz+iE3CLgScGkWH6s8QZaHGzZsMJZVOg0bntovkJDZ8KrMplbVo2jumvp3yQPQZqo0CUs QfEa/OExuBu090xzY7lE6EFDASoM9LjEu+P9Vnr4dhJaNrON+bIth8U9Qa7b1gHY+NJVoQlj 6mJvf72wFjB7eQ/XG3ukpWcE7VEuJepV+1NP8OrdHRXkENugiM3D8fvL4xgFaF0rQ==
  • Ironport-hdrordr: A9a23:1u8FxayjkUUJsUURfG/GKrPwFL1zdoMgy1knxilNoRw8SK2lfu SV7ZMmPHjP+VAssRAb6LS90ca7LU80maQb3WBVB8baYOCEghrMEGgB1/qA/9SIIUSXnYQx6U 4jSdkdNDSZNykDsS+Q2mmF+rgbruW6zA==
  • Ironport-sdr: Q+XJI9wdNLIj148Q7AjLHyTgOVp1XL789t9Y5BN1Bk6u6cgeHcikVqdHT4fOfTWCTy70ZsnMBO ALPuVPqQLrjgqYoWcR3JQqUeKcQT94FOlMw7Jb/duX0ujqdGn+8E1vEq8rGKdvC9XnpMkbGf11 RNfU33UwLFPkPLC/GTefjkj9I+N2CmFNIsXopK1KT84pllCKB2IobDRyxGBWIeozvtn0iwxWFU wLJfzLOspDyb0GywIkIpIOB+0N02m1ao/IX5O9soM7+EqFdTcKp+hydC0PYk2o7r8evra1WcsR rqth1ApE5lfLYlB5oA61tG5b
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Thu, Nov 04, 2021 at 03:49:36PM +0000, Alex Bennée wrote:
> 
> Anthony PERARD <anthony.perard@xxxxxxxxxx> writes:
> 
> > Patch series available in this git branch:
> > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fxenbits.xen.org%2Fgit-http%2Fpeople%2Faperard%2Fxen-unstable.git&amp;data=04%7C01%7Canthony.perard%40citrix.com%7C85bb0d32a72542aa9f6108d99fad9607%7C335836de42ef43a2b145348c2ee9ca5b%7C0%7C0%7C637716390172120458%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=WWS4yPu9%2BJxBkBiM5SBrH7kDtHkUzMGuKSSdPcgEYII%3D&amp;reserved=0
> >  br.build-system-xen-v7
> >
> > v7:
> >     Out-of-tree build!
> >
> >     This mean many more patches. Everything after patch 27 is new.
> >
> >     There's a few new patch before that, but otherwise are rework of
> >     v6.
> 
> This is something I've been looking forward to but obviously my QEMU
> focused mind meant I did it wrong. Generally I create a builds subdir in
> my tree with subdirs for each build flavour. So with:
> 
>   /home/alex/lsrc/xen/xen.git/builds/native
> 
> And executing:
> 
>   ➜  ../../configure

Thanks for testing, but the patch series only focus on a subset of the
repository, that is the hypervisor "xen.git/xen/". The rest of xen.git
isn't ready for out-of-tree build unfortunately. A lot more work is
needed.

> In "build: adding out-of-tree support to the xen build" you describe the
> Linux kernel style which works well where the config can be done after
> the fact but I wonder if the configure approach is better suited to
> something that needs a bunch of checks running. Is the configure script
> pure autoconf? This should work out of the box IIRC.

"xen.git/xen/" does use a build system similar to Linux's, we use
Linux's Kconfig for example.

For the rest of the repository, it is indeed autoconf for the
configuration phase. So yes running ./configure would be mostly ok, but
it doesn't take care of Makefiles at the moment and I found one bug in
our autoconf macros. Beyond that, our Makefiles aren't ready.

xen.git isn't a single build system, they are several (at least one
foreach of xen/ stubdom/ tools/)

Cheers,

-- 
Anthony PERARD



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.