[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 6/7] xen: Switch to byteswap.h
- To: Lin Liu <lin.liu@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 2 Nov 2021 16:23:15 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FRia4D1qA31mkef0NY01MZn2Qmj8+Iy0JRLsQc6vzno=; b=VqV/YLD93EpYLFHCez0AqXlNRhVBIrBahSqVLe2egMfCb8Is0QulzweY5gCNmN7ojU46LV/+QiA+wi1KhIrPUd1MHRvBPzFgTPcPCtBRwZzOgx+pV3XDyX6yV99p4zPXYBZ74b6yevMW5yTXhpckE1sRc57xAy25rAVorju2KasCezLp+u0M7MyLKgXmQs61xXk7HljSKA+lB8Xax9NSYICi55UWm3HzkPMqQCZ70Wh8WmykUTwKlHXOrtQfJXe4le3T0Ehg0t/osEf1cGRcwNZVWIdDta2gGOqox7xtOdYkdHP9nX39J0MMni1Eh7t4rwTJcQg1IAKCiX0Lyba49Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Fv5ii3a6sysRu4c/6q4T3SoiKu7TcxnEFzKVcgINxcusZ6IREsQ5k4/JZIPQbUiUVW1rxGsiT5WS0lFVKbAn8lth8mum6FqIgbwRC/2b4+7lXj09lqgOn9UTRoZt+ngAnvZY9DLpcolu4Opku2WBtuaoaRNvm/T06pBH3vVGyAtrAFCV5p9Rq7kMJTXvdXIoJbpRbJXaTc+Jlyh5yGltas0PEGzQgh0kmRGHRjTKEpkeRZn2+qD2eOyEOf56eKREZ9jMXvNbjCPlJ1UpS+e1FpNaVY3fF0T3yMxP6xFGVDVO5MXVxJLoowkBQyfBhnDXU/xV3amkD7KzEzUtkQ8N/w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 02 Nov 2021 15:23:34 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 22.10.2021 12:47, Lin Liu wrote:
> @@ -28,7 +28,7 @@ static inline void put_unaligned_le32(u32 val, void *p)
>
> #endif
>
> -#define get_le32(p) le32_to_cpup((const uint32_t *)(p))
> +#define get_le32(p) le32_to_cpu(*(const uint32_t *)(p))
While here the adjustment may be okay as there is already an
open-coded cast, ...
> @@ -20,7 +20,7 @@
>
> static inline uint16_t get_unaligned_be16(const void *p)
> {
> - return be16_to_cpup(p);
> + return be16_to_cpu(*(uint16_t*)p);
... here and below you add open-coded casts. Is there a reason you
don't retain the ..._to_cpup() macros?
Jan
|
