[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/hpet: setup HPET even when disabled due to stopping in deep C states
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 2 Nov 2021 13:26:51 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dsPt4LEVFwOi0Ya6VAsEssnSXim3fq8f6SBJOmXnPps=; b=gZfxdgeT+8MhVJ9t2RQh0yUroddT6F2lKPo0RdzchTQm8nro0ARgMCrxZPHNoE7fRSMdVQHWpa4mMh5gFrPnb0I1rsBXOPb0owVNdOhiJ2upInuvmve/N1QecfA9ayT/9gLdZO6YayAMMWaTnRL0wHxlhxk1qywOvU/rcywvYhmjGLsCtoVBcrte0ZDEzEBdhGIV7nV9hvOd46cP+z9WjhjhlbMqttFto5nvnnHSTPMJWj93PMH9mKGgeV06dp9l1kVH0T2UI8R/VMZfARIZatC80nwbJN4v1gFTBoDTkeSNpbeXnVwaehfdXinc0U9yKkgDeXCYBEWT3K0TY7TG1g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ciMj6PefBdHpUfsxYFiQukhnm6riMNDBFUvzt240VQH0Y1kQs0FviaII4d+SjY+4mOkokcq8xM9NnganZiU2dbu3qW7XDZ1kjRfA9H3lW8RJeE8JUpVpcR1dI629duDDW3ngxs/HwR6ygaBgS2vheia/iajETORplRBPCatUSV5Ul4QjCbTDtTcPvivJ6B03/dDwG5gxvlz9AhehP2y2AXbDYpPy0WM9U9KOj/aXBTzUicU1DEPjl6ZLdds4IQH26fmaEeTZmbvaLqAhXFmr4hrdomxR2MlUA1uAJIhYGpNOh/xBckBP7xYwVqAQmOZHRVIrLX1Pg1+fsD2OF7UWgg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 02 Nov 2021 12:27:09 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 26.10.2021 17:12, Roger Pau Monne wrote:
> Always allow the HPET to be setup, but don't report a frequency back
> to the platform time source probe in order to avoid it from being
> selected as a valid timer if it's not usable.
>
> Doing the setup even when not intended to be used as a platform timer
> is required so that is can be used in legacy replacement mode in order
> to assert the IO-APIC is capable of receiving interrupts.
>
> Fixes: c12731493a ('x86/hpet: Use another crystalball to evaluate HPET
> usability')
I realize this has gone in already, but imo pointing at this commit is
only part of the truth (maybe the larger one). e1de4c196a2e ("x86/timer:
Fix boot on Intel systems using ITSSPRC static PIT clock gating") post-
dates d5294a302c84 ("x86: avoid HPET use on certain Intel platforms")
by over a year, yet it's that patch'es logic which the referenced
commit merely extended. I am of the opinion that e1de4c196a2e should
have made the adjustment you make now, and hence should (also) have
been tagged.
Jan
|
