Re: [PATCH v2] OSStest: explicitly enable building qemu-traditional

[Ian Jackson <iwj@xxxxxxxxxxxxxx>]

Ian Jackson writes ("Re: [PATCH v2] OSStest: explicitly enable building 
qemu-traditional"):
> Juergen Gross writes ("[PATCH v2] OSStest: explicitly enable building 
> qemu-traditional"):
> > It is planned to no longer build qemu-traditional per default.
> > 
> > In order to be able to continue running tests with ioemu-stubdom run
> > configure with --enable-qemu-traditional.
> > 
> > Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> 
> Acked-by: Ian Jackson <iwj@xxxxxxxxxxxxxx>
> Release-Acked-by: Ian Jackson <iwj@xxxxxxxxxxxxxx>
> 
> And pushed to osstest pretest.  I will let you know how it goes.

This passed the self-test (so it is in producetion), but, I observe
that it does this[1]:

                   if grep -q --  tools/configure ; then
                       qemutrad=
                   fi
   ...
   + grep -q -- tools/configure

I think this only works because the build has its stdin redirected
from /dev/null.  That's not going to change so it's not a bug but it
seems quite odd and possibly a latent bug.

Thanks,
Ian.

[1]
http://logs.test-lab.xenproject.org/osstest/logs/165863/build-arm64-xsm/6.ts-xen-build.log
http://logs.test-lab.xenproject.org/osstest/logs/165863/build-arm64-xsm/info.html