[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/3] x86/APIC: avoid iommu_supports_x2apic() on error path


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Mon, 25 Oct 2021 10:41:40 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XcoCoCwpF0C5d/Kg1OE+tUYQhaSjK7jInv6zyutyTPs=; b=AfWVE8qGWU2Suod2z59nZ/xzqT8Su01DGgDaqwbDeZIaIUaGSXJw1EpJkdkCNFtS/4xecEWazDQlngIUCpMq1gNGQ+wZyi0i+hXjjnvYoIadDzuRxX0xLNVOHV10WW1qgxsq9O+8fOXUgHSoF0x4m5PDzuMis8tp/l+qzTNCLl/8EpaJy0IzYt+y26t+67XEztPRJ+NrkktH0xXd/2rwPUQbAkCXjJLqrdBXD2xXPI1hZAUQSufkqDdiE4xIBu1zzNJ1pFarVND+dbY/+wPE4EoN0YtTpfZyB15qwkbYxp4kghG4Oa+6PXGLUX+cPpCpDeEi55Fg5GT+ienWti7gVA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hc3RHe8qm9+5FwwW3xwF3YX9Q5mKntb0loGyiGC74Pj9z7NHUB35VU+SiJiZ1geyiOqYc+JkpiPHLgJguZuMLY0VVkWoKALQmWpAN7HPrVP50EF/jj9Y43DB2UgpEey8HuybeB5K1PnMF7dSdUbp7xtlvEaVbQJ2fxtlUnY99dVCVOxOPvFLSZml1HaCq+LVLaMax0sn3rB3GPQc5PgCDciY66T8ri1WttQbm81qWTbUeltN9rWcRbsxx+/0UF6oDYR65sN5Quplc67h8AIx2YJrMXyeNMWOuxecNT4Bdbm9j/fk5Oc2e1koqgM4IF6i7PIjFseDzpohSkMsH2zVvQ==
  • Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Paul Durrant <paul@xxxxxxx>
  • Delivery-date: Mon, 25 Oct 2021 08:42:09 +0000
  • Ironport-data: A9a23:vAWuKKp+n2Cz9xlImqrQ2Pw1IO1eBmL6YhIvgKrLsJaIsI4StFCzt garIBnQaf+PNDD1coxxOY2w8U4AuZ6Ay9YwSlBlry5nRitDoJuZCYyVIHmrMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dnd+4f5fs7Rh2Ncx2YLlW1nlV e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9 DlCnbu1ayYAI/3toeU6UBtFLCVlMLxX3bCSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFJkYtXx6iynQEN4tQIzZQrWM7thdtNs1rp0RTamPO 5BIAdZpRBntSjhsM3knM40nwdiDhmDPdAZU903A8MLb5ECMlVcsgdABKuH9ZdiiVchT2EGCq Qru523kBjkKOdrZziCKmlqujOLSmSLwWKoJCaa1sPVthTW71mEVTREbS1a/if24kVKlHcJSL VQO/SgjprR081akJuQRRDXh/iTC5ERFHYMNTatqs2lh15Y4/S6+A0olZyMRSeUnk8w0WAMuz VKYjvbmUGkHXKKudVqR8bKdrDWXMCcTLHMfaSJscTbp8+UPs6lo0UqRFocL/Lqdy4SvQ2mpk m/iQD0W3u1L1aY2O7OHEUcrat5GjqPCSRIp/U3pV2ah4xIRiGWNNtHwtwazARqtKu+kori9U JosxpD2AAMmV8jleMmxrAIlR+nB2hp9GGeA6WOD5rF4n9hXx1atfJpL/BZ1L1pzP8APdFfBO RGI5FoJvMUCZCPwPcebhr5d7exwncAM8vy+DpjpgidmOMAtJGdrAgk3PSZ8IFwBYGBzyPpia P93gO6nDGoACLQP8dZFb7x17FPf/QhnnTm7bcmil3yPiOPCDFbIGeZtGAbfNYgRsfLbyDg5B v4CbqNmPT0EC7agCsQWmKZORW03wY8TXMGm9ZcPLbXdc2KL2ggJUpfs/F/oQKQ894x9nebU5 HCtHEhezVv0n3rcLguWLHtkbdvSsVxX9xrX5AQgYgSl3WYNe4Gq4PtNfpc7Z+B/pudi0eR1X 78OfMDZWqZDTTHO+jI8a5jhrdM9KET31FzWZyf1MiIie5NARhDS/oO2dAXY6yRTXDG8stEzo uP821qDE4YDXQlrEO3fdOmrkwGqpXEYle8rBxnIL9BfdV/C6o9vLyCt3PY7L9tVcUfIxyeA1 hbQChAd/LGfr4gw+djPpKaFs4b2TLcuQhsERzHWtO/kOzPb82yvxZ57fNyJJT2NBnnp/KiCZ PlOy62uOvMwg1sX4ZF3FKxmzPxi6oK39aNa1AltAF7Cc0+vVuF7OnCD0MRC6v9Ny7tetVfkU 06D4IAHa7CAOcejG18NPgs1KO+E0KhMyDXV6P00JmT85TN2o+XbARkDYUHUhXwPNqZxPaMk3 fwl6Zwf5AGIgxY3NsqL03JP/GOWI31cC6gqu/n22mMwZtbHHr2aXaHhNw==
  • Ironport-hdrordr: A9a23:bcdF0K7orInsdGXIjwPXwVKBI+orL9Y04lQ7vn2ZFiY7TiXIra yTdaoguCMc6AxxZJkh8erwX5VoZUmsj6KdhrNhQItKPTOWw1dASbsN0WKM+UyDJ8STzJ856U 4kSdkDNDSSNykKsS+Z2njALz9I+rDum8rJ9ISuv0uFDzsaE52Ihz0JdDpzeXcGIjWua6BJcK Z1saF81kWdkDksH46GL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftzLLhCRCX0joXTjsKmN4ZgC T4uj28wp/mn+Cwyxfa2WOWx5NKmOH5wt8GIMCXkMAaJhjllw7tToV8XL+puiwzvYiUmRsXue iJhy1lE9V46nvXcG3wiRzx2zP42DJr0HPmwU/wuwqrneXJABYBT+ZRj4NQdRXUr2A6ustn7a 5N12WF87JKEBLphk3Glpn1fiAvsnDxjWspkOYVgXAae5AZcqVtoYsW+14QOIscHRj99JssHI BVfY/hDc5tABCnhk3izytSKITGZAV3Iv7GeDlMhiWt6UkXoJgjpHFogPD2nR87heQAotd/lq P5259T5cNzp/ktHNVA7dc6MLiK41P2MGfx2UKpUBza/fI8SjnwQ6Ce2sRA2AjtQu1P8KcP
  • Ironport-sdr: gzYzcB6pF+yuqzlrao5ZzTfOfky618Ec308c1N7OYuEMsCPC/ezL82AxSYQj201pCGyCVPKxN0 w8kHVhX4GLCYnTRND99NXtRUHa2M8kuWvU4+B0ETs2Hx70dOvN4chIvC7hXdEK8abzhYpePYR/ JQfHEpGrOsbKVzb7dJ3gOg0/ftRbgrYAI9foHPU5iIMoK5W/BxvPf9GMbfTU8d+eCZyw4oZAQg n53hvC3kzDOrY/QLXmgFVAEOTRgB29QUmvej+jtqRlT73RTRNKMQmuxhy5VuU9kQcTEasm0+nC 7MvIUJqThPBO8mCUbpNKAPdK
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Thu, Oct 21, 2021 at 11:58:37AM +0200, Jan Beulich wrote:
> The value it returns may change from true to false in case
> iommu_enable_x2apic() fails and, as a side effect, clears iommu_intremap
> (as can happen at least on AMD). Latch the return value from the first
> invocation to replace the second one.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.