Re: [for-4.16] Re: [PATCH v4] xen/arm: vgic: Ignore write access to ICPENDR*

[Julien Grall <julien@xxxxxxx>]

On 21/10/2021 16:14, Julien Grall wrote:
> On the previous version, we discussed to include the patch for 4.16. So 
> please tag it with for-4.16 and CC the Release Manager (Ian). This will 
> help him to track what's outstanding for the release.
> On 21/10/2021 13:03, Hongda Deng wrote:
> > Currently, Xen will return IO unhandled when guests write ICPENDR*
> > virtual registers, which will raise a data abort inside the guest.
> > For Linux guest, these virtual registers will not be accessed. But
> > for Zephyr, these virtual registers will be accessed during the
> > initialization. Zephyr guest will get an IO data abort and crash.
> > Emulating ICPENDR is not easy with the existing vGIC, this patch
> > reworks the emulation to ignore write access to ICPENDR* virtual
> > registers and print a message about whether they are already pending
> > instead of returning unhandled.
> > More details can be found at [1].
> >
> > [1] https://github.com/zephyrproject-rtos/zephyr/blob/eaf6cf745df3807e6e
> > cc941c3a30de6c179ae359/drivers/interrupt_controller/intc_gicv3.c#L274
> >
> > Signed-off-by: Hongda Deng <hongda.deng@xxxxxxx>
> While I agree the Reviewed-by from Bertrand should be dropped, the 
> Release-acked-by from Ian is simply a way to say he is happy to include 
> the patch for 4.16. So this should have been retain.
> The patch looks good to me, so I can add Ian's tag on commit:
>
> Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>
Committed.

Cheers,

--
Julien Grall