[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/7] fs: remove __sync_filesystem


  • To: Christoph Hellwig <hch@xxxxxx>, Jens Axboe <axboe@xxxxxxxxx>
  • From: Chaitanya Kulkarni <chaitanyak@xxxxxxxxxx>
  • Date: Tue, 19 Oct 2021 06:33:00 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U2HxfBZTSi3BiVqoiVet04dkczzLVkaskpQSpA/YG+U=; b=gezdel1F4b1RrY9ZRyQx0khy7BUnjqBm3fXam3NrcoZ8tchV+hjPsPDJvatJCS/ZQVcFnzBwIfVGF0Teyh4xd03C9ttGjsfrQ3tivVlNway6bPJfY3PyOG365C1uRgVVSHfFuD9S8P5VitL2Al6JtTPzcixhX2sahm4glf1x4KNelos84pZP8p/oUPkKCR76I+CpQ7l22oRlLvyJZ/OyPcgQJS9LLgBXYGAdLTkD6YtnSwkhXfmMhSrUH3G4gJRek1fs8fDa491DhiB/TalGKRyoGUly/MHHSpCz8TCFxlZdfGCzZEO2vmThjiaGBiJ9vsnuuP21KVcAf0OiIsOuIQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FNuOoiNsx1/FHJsfp54axQLE/+3bN/gl9Iux9VardD19HamvJXiJTcJv0trtYVj32hVb2P+pjRe8lpZuOV3/7CstEJc36QnJjgZPV0ZAqW+KyW3fbvwdBS53uRLMk4cDxR38IiUEm/2nmgSt0wBWBvIZkWxn/+oAGGo0lE2VdyzGuGHBivMv+XtFHh0XY/iukc74D3ZAemhvwEzFpcAve3W6AfDyE+pMV2GgnK1/uwElMVoz7smLITM6hV+cP97sz5XxmlvbN2LbAs9pKKSrf4GDiOUyRcU48Z5vu+7xpAGpzN+Bs4UsBwn21WziIRK8bmvJNo/EC0DAfB6g4v5xUQ==
  • Authentication-results: lst.de; dkim=none (message not signed) header.d=none;lst.de; dmarc=none action=none header.from=nvidia.com;
  • Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Josef Bacik <josef@xxxxxxxxxxxxxx>, David Sterba <dsterba@xxxxxxxx>, OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>, Konstantin Komarov <almaz.alexandrovich@xxxxxxxxxxxxxxxxxxxx>, "linux-block@xxxxxxxxxxxxxxx" <linux-block@xxxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "linux-btrfs@xxxxxxxxxxxxxxx" <linux-btrfs@xxxxxxxxxxxxxxx>, "linux-fsdevel@xxxxxxxxxxxxxxx" <linux-fsdevel@xxxxxxxxxxxxxxx>, "ntfs3@xxxxxxxxxxxxxxx" <ntfs3@xxxxxxxxxxxxxxx>
  • Delivery-date: Tue, 19 Oct 2021 06:58:26 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHXxLIm30uqtC6wVk2XNPvmvYapJKvZ3O4A
  • Thread-topic: [PATCH 1/7] fs: remove __sync_filesystem

On 10/18/2021 11:25 PM, Christoph Hellwig wrote:
> There is no clear benefit in having this helper vs just open coding it.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Especially if there is only one caller.

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@xxxxxxxxxx>



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.