[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI support for ARM [and 1 more messages]


  • To: Ian Jackson <iwj@xxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 18 Oct 2021 13:04:25 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HT3bgD1N2M3YaOibhdjUYNEepol+J8HxI2jA1wA9PIo=; b=FbyHvVWM68xZz2m7LlQt8R+SpFTZW6tfZWcnFZw+qpqRWrPIO61CRg8LfJdULLAut1jebIG1IvcNgq52TXKTI7ZNU7/7Xj6beKvVnAhpraDVsF4x1mLNtpWMh8THyQFavz1buXgGKlBBBxGM1Roz0KGe/by5Q4MMTvuzgZM8inwfuhX90JtdLj4QY7kFYx7IXl+zHP3bJJ0srRr3G/mNRHYoZ5TFP7PMiSm7CJzKuzCSFOb2FeDykdyc9a2cxqwxA8HP6+ylHR24w5lkVJtxyzyxenOTtYu11OtNE0iSwrhU9Ibr89I03rW5+mq32rqdxJQVRTP9+NY4MPV6gZyHbg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i6jpUNQciW16pLd4BcYEZ5JsGR+I/65hdeSHwoCGpmy/+JMnGNwyAeFNtH2iIwW/yF3NHVwEFe35O+ByC9oPBTnX279HfQb2sccpC2LTlEWOyBkqHW0tz8BMHpb7Q1DjsxFUN2dgd+0hwPJGfXrHkS1kw+/vqH6lL1Lddf+c8/JwJ3ONAT/zJa3K9jrvA1OKmRklJU0WSVBy6z12WVxtJzld5oeQFXqYipQnKgVPETQyruHtmiDFGucfUl2TOqY6bidV4K+pIqn+6eTzg7PnZg3C4q8fnuCR4X20RGRnLphmOeiorkjL/22sSQL5kk6CSPI4ZAA+2nXTSxwFNM1Bgw==
  • Authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=suse.com;
  • Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, Rahul Singh <Rahul.Singh@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Paul Durrant <paul@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>
  • Delivery-date: Mon, 18 Oct 2021 11:04:34 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 18.10.2021 12:38, Ian Jackson wrote:
> Julien Grall writes ("Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 
> virtual PCI support for ARM"):
>> AFAICT, the code is not reachable on Arm (?). Therefore, one could argue 
>> we this can wait after the week-end as this is a latent bug. Yet, I am 
>> not really comfortable to see knowningly buggy code merged.
> 
> I agree that merging something that is known to be wrong would be
> quite irregular, at least without a compelling reason.
> 
> Jan Beulich writes ("Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 
> virtual PCI support for ARM"):
>> On 16.10.2021 12:28, Roger Pau Monné wrote:
>>> Maybe I'm being pedantic, or there was some communication outside the
>>> mailing list, but I think strictly speaking you are missing an Ack
>>> from either Jan or Paul for the xen/drivers/passthrough/pci.c change.
>>>
>>> IMHO seeing how that chunk moved from 3 different places in just one
>>> afternoon also doesn't give me a lot of confidence. It's Arm only code
>>> at the end, so it's not going to effect the existing x86 support and
>>> I'm not specially worried, but I would like to avoid having to move it
>>> again.
>>
>> +1
>>
>> I'll be replying to the patch itself for the technical aspects. As per
>> context still visible above this code path is supposedly unreachable
>> right now, which makes me wonder even more: Why the rush? Depending on
>> the answer plus considering the __hwdom_init issue, Ian, I'm inclined
>> to suggest a revert.
> 
> I don't want to be waving hammers about at this stage, and I haven't
> looked at the technical details myself, but:
> 
> Can I ask the ARM folks to make sure that this situation is sorted out
> ASAP ?  Say, by the end of Thursday ?
> 
> By sorted out I mean that the __init_hwdom issue is fixed and that
> the overall changes to xen/drivers/passthrough/pci.c have been
> properly approved.
> 
> Furthermore, I think these followup patches should go in all in one
> go, as a small series, when everyone is OK with it, rather than
> dribbling in.  That will make it easier to see the wood for the trees
> (and it would also make a revert less complicated).
> 
> Jan, are you OK with this approach ?

Yes. FTR I'm not fussed about "all in one go" vs "dribbling in".

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.