[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v7 42/51] build: grab common EFI source files in arch specific dir
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 18 Oct 2021 10:48:26 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PA0iWdDJYyeaEKNMoAovVP9ZkLAROthSOpvLGJf88i4=; b=Xc+MT7F85WRqn1lrKYB9TnKdBhbkLFWGMe/ImDtribXxW6EQ0bwIdQ7guAW+06Y1LmVyTSXzCUeaqSswA5VfokDdQ38fX/B8jXEh8tuQ1BcFPlgc7keKEEUpfuTSHsZDzqJIcH0C2HRXdREQzoxC90/fa4cRalFyg6gvdJwkBR5MuIpMVxTcIsiXrWujuCI/BndTgvovA8uo91JTCM4mj9fL4ROwJWiXRbTpG79ausmIhgtbGByur7SBryjDl04v+OcUCjciCqdVYVmdHJNffe3REcu3TTfqtXVqcHXt2GP5w969KipkuboAsvHOHbjtMVGrDnMu7t5EH3/uR7cSkA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PCO+9yLrOw2RuHzxxsfcO5N7rYudLiU5Ekokt3E4j16aH6lfAQzUh3eA+y1v981BpaFKSEnaZPWd5pTrai2SZ2dgDLAc75B1P42C3UBMfz2Q7Or11edfOJcSDU1H7SggL9QvH38F1U1g2GHc8EXkfEerOyOv7B4SH2PRZtlFke5VqFkGniNFoQQYWFi+dXm2g2kEKL5oBSdTRtMcz4zABKhl5/NoxJNl3d4jmCB2ACgXJf4nzG44HZ0xMDkEfYXx5CeoEsgc/U19w3K7qj/tshGw2DlU5+UjJ9G+20XY6zJ7bqR0688ZOAeP+jDNq23KJES2tV9GaDovoYHix4t6Pg==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 18 Oct 2021 08:48:45 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 15.10.2021 18:29, Anthony PERARD wrote:
> On Thu, Oct 14, 2021 at 10:51:44AM +0200, Jan Beulich wrote:
>> On 24.08.2021 12:50, Anthony PERARD wrote:
>>> --- a/xen/arch/arm/efi/Makefile
>>> +++ b/xen/arch/arm/efi/Makefile
>>> @@ -1,4 +1,10 @@
>>> CFLAGS-y += -fshort-wchar
>>> +CFLAGS-y += -I$(srctree)/common/efi
>>
>> Perhaps another opportunity for -iquote?
>
> Yes.
>
>>> obj-y += boot.init.o pe.init.o ebmalloc.o runtime.o
>>> obj-$(CONFIG_ACPI) += efi-dom0.init.o
>>> +
>>> +$(obj)/%.c: common/efi/%.c
>>> + $(Q)cp -f $< $@
>>
>> In case both trees are on the same file system, trying to hardlink first
>> would seem desirable. When copying, I think you should also pass -p.
>
> I don't know if doing an hardlink is a good thing to do, I'm not sure of
> the kind of issue this could bring. As for -p, I don't think it's a good
> idea to copy the mode, ownership, and timestamps of the source file, I'd
> rather have the timestamps that Make expect, e.i. "now".
Why would "now" be correct (or expected) in any way? The cloned file is no
different from the original. Nevertheless I agree that -p is not ideal;
it's just that the more fine grained option to preserve just the timestamp
is non-standard afaik. You could try that first and fall back to -p ...
Otherwise, failing hard linking and using "cp -p", I'm afraid I'd prefer
symlinking despite the arguments against it that you name in the
description.
Might be good to have someone else's view here as well.
Jan
|
