[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Revert "xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag"


  • To: Michal Orzel <michal.orzel@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 14 Oct 2021 10:53:18 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9lDL5J4suLmGGcmf7KGrdWh7Ht3QbfuMeeRREq/BDAA=; b=M38FxTKjc5RbzZJke4H5Zg4ojwjYbrplksaH9OtTdCFeePqrgJvFV4FVkvY7pnuWLmhoIZjHet0AGOmPrboqZobe5OekDrNQZZcGErhoG7xBYPtm0r10qCcia9/LT/7EGgBB93I+1WNKagdQg0ZUfnB2ry8oOR4jJXFqEXLEzSTGMg6ZDmELiKXO7xbN9MQB89aSCGxXX5TJEP8CQ1D2GNwSWpMNxcNcZ9h4nR0oFve3Y4JkgofkhGDbDoPdITLcyljU9THCdzsRJx2Ta9ZnmZzYWCGgMxZtVJfmSgYBELzA87PLPAtFgctesVd44SCPaPsoOAXhNJ1YGvCaB5E7Lw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZuAeh15X7nHiLqHk3TSmIDPc/v0PlFFZ/LkZlARHmeXoofX/6lgq14cHWgM0KvbBtIATaPoPQoZGDo4A18rphC8VuZI3T7DRG/1XR8zIzM+3PQNYwzSC+DMbdYc1JP1mfSuqrcKI49fidR2HaM0SPlzEcgC6KbM+3n2ojcLgbwkozqgA8CueQaXNvfiCZJXCCvVsWdqG9S7jTm0/L0sYf5x+Fs1aR288/705Z3vG0GcsQUY7UXa+8YyMk2WMIb0p06I1qRxbfCnwT63w0UeWH7CKxOMSkoyqMRC3HwdN8XVdjn7MYM2QoJ/vvs6FbFUSRt/GAt6D4XmsME44BNDLXQ==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: Christian Lindig <christian.lindig@xxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, bertrand.marquis@xxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Thu, 14 Oct 2021 08:53:30 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 14.10.2021 10:47, Michal Orzel wrote:
> This reverts commit 2075b410ee8087662c880213c3aca196fb7ade22.
> 
> During the discussion [1] that took place after
> the patch was merged it was agreed that it should
> be reverted to avoid introducing a bad interface.
> 
> Furthermore, the patch rejected usage of flag
> XEN_DOMCTL_CDF_vpci for x86 which is not true
> as it should be set for dom0 PVH.
> 
> Due to XEN_DOMCTL_CDF_vpmu being introduced after
> XEN_DOMCTL_CDF_vpci, modify its bit position
> from 8 to 7.
> 
> [1] https://marc.info/?t=163354215300039&r=1&w=2
> 
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
> ---
>  tools/ocaml/libs/xc/xenctrl.ml  | 1 -
>  tools/ocaml/libs/xc/xenctrl.mli | 1 -
>  xen/arch/arm/domain.c           | 3 +--
>  xen/arch/x86/domain.c           | 6 ------
>  xen/common/domain.c             | 3 +--
>  xen/include/public/domctl.h     | 3 +--
>  6 files changed, 3 insertions(+), 14 deletions(-)

Applicable parts
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.