[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 0/3] Expose PMU to the guests


  • To: Michal Orzel <michal.orzel@xxxxxxx>
  • From: Christian Lindig <christian.lindig@xxxxxxxxxx>
  • Date: Tue, 12 Oct 2021 08:25:53 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ji27IzYFNo9CFef/uxdfYVof40kw6Z47Kly80gm8LMc=; b=NT4Hq4i2zXZ/BUcwbWV0Kaprk+3B69AVo8OzaOkToWTo+sp4x9JSE6xik6sJbafnJK8c8GPqt0fW5cV2uqD1ho2rfCe2KpJjvc5mfFVVcsD6NQrn1fgJtfdSkUFVRkQbrWp2BYs3Ux8eL2mS9mdWzqAAhKzrlGAbMJ69gKYxxCtXL9JLsjA7EStI2q79zN24+qHqzZKqzxRsL0Umce4DN8HrcrdEB0M4HX6b0DmeGIcE6B1qR2t17LQSazQYE2aKRezeFHw9oqbMgudqsDyj+He2ixCefbFhzNbRQ/g+Imav1MmSHDHMoUcelM1g+4fhidoqj2Fa3G98CXmLYJ931g==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BEEwxDpZlUNMhh6Qij5nKYBtjQzFxGQU8vN3eeosAYDXnoTgdmDzglVAMWbZLHxgISr/wp1GVH/P6dhS4e5j6kemGzx8gplMtMAQ0J35BBMen3iHD+ozsecm/tKckCUG+7TppUEC5KytFBzkICXWhtPonBHp5H9+G3sFyFSvlBsa3ChF64Fi6PpxUjnV1mFyi02zzr46rlxsEtvrYjzwUui4cuZMEEfJ9lb/zaEvV4/MmFAbUmSV/3q2XmN7A0yhEKKNrBs+L0L//cNrdmUw+43/ZZ5dsLSxyopNkiGlSo7PFKhFUuQtV+Lo68Zx7ZKXUdwRHFv5M6gPhVcDKtZFWg==
  • Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "George Dunlap" <George.Dunlap@xxxxxxxxxx>, Nick Rosbrook <rosbrookn@xxxxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, "bertrand.marquis@xxxxxxx" <bertrand.marquis@xxxxxxx>
  • Delivery-date: Tue, 12 Oct 2021 08:26:12 +0000
  • Ironport-data: A9a23:3VqLG6ANOeDEyRVW/wvlw5YqxClBgxIJ4kV8jS/XYbTApDlxgjECx jAZXjvQa/6PMTb2e9klOtvj/EIAv8PWz4c1QQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WLOs1hxZH1c+EX550Eg7wobVv6Yz6TSHK1LV0 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/kT6nsstO6 fp3hJ2wQjl1Yqfcnd4+XEwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr KFGbmBWBvyAr7veLLaTQel2h98/LcDteocevH1hwhnSDOo8QICFSKLPjTNd9Gps15ARQamBD yYfQWF2XUqbOxNlARBUUa4ujt7zt3XCdyIN/Tp5ooJoujOOnWSdyoPFMtXPfceRbd5IhUver WXDl0ziGQ0TPtGbzTuD81qvi/XJkCe9X5gdfJW66/prjVu71mEVThoMWjOTq/SjllS3Xd4ZL kUO4zcvtoA77kntRd74NzWGp3qDsg8ZSsBnOeQw4wGQyYLZ+w+cQGMDS1ZpZNU4uecsSDct1 1vPmMnmbRR1t6afU3Wa9bG8pDK0Ny8OIGREbigBJSMV7t+mrIwtgxbnStd4DLXzntDzASv3w T2BsG45nbp7pcsK3KWy+RbAmSChorDAVAtz7QLSNkqn5A5kYI+uZ6Sz9EPWq/1HKe6xUV2pr HUC3c+E44gmDI6PvDyARv0XG7Ok7OrDNyfT6WODBLF4qW7roST6O9kNvncufy+FL/roZxfza 2H+ojxwy6ViPXuhU/MraZK0MeclmP2I+cveatjYad9HY55UfQCB/T1zaUP4410BgHTAgolkZ s/FKZfE4WIyTP09lmLvFrh1PaoDn3hmnQvuqYbHIwNLOFZ0TEWeTqsZKxOwZ+Q94bLsTO79o osHaZXiJ/myVoTDjsjrHWw7cQ5iwZsTX8meRylrmgireFQO9IYJUa65/F/ZU9Y595m5b8+Rl p1HZmdWyUDkmVrMIhiQZ3ZoZdvHBMgk9iNkYnx8Ywj1hxDPhLpDCo9FKfPbmpF9pYReIQNcF aFZK61s/NweItg4x9jtRcak99EzHPharQmPIzCkcFACk21IHGT0FivfVlK3rkEmV3Pv3eNn+ uHI/l6LEPIrGlU5ZO6LOa3H8r9ElSVE8A6EdxCTeYc7lYSF2NUCFhEdeddue5tSdk6ZmmfDv +tUaD9BzdTwT0YO2IChrYiPrpuzEvs4GUxfHmLB6q2xOzWc9W2mqbKsms7RFdwEfG+rqqike 8tPyPTwbK8OkFpQ6tIuGLd316MuodDoouYCnAhjGXzKaXWtC69hfSbajZUe6PUVy+8LoxayV 2KO5sJeZeeDNvT6HQNDPwEidOmCi60Zw2GA8fQvLUzmzyZr577bA15KNhyBhXUFfrt4OY8o2 8k7v8sS51DtgxYmKI/e3CtV636NPjoLVKB+7sMWB4riiwwKzFBeYMODVn+qsc/XM9gVaxskO D6ZgqbGlo9w/EuafiphD2XJ0MpcmY8K5EJAwmgdKgnbgdHCnPI2gkFcqGxlUgRPwxxb+OtvI Ww3ZVZtLKCD8jo01shOW2egR1NICBGDoxGjzlIIkCvSTlWyV3yLJ2o4YL7f8Ecc+mNaXz5a4 LDHlzq1DWe0JJn8jnkoREpoi/3/VtggpATNlfeuE9mBA5RnMyHuhbWjZDZQphbqaS/raJYre QW+ED5MVJDG
  • Ironport-hdrordr: A9a23:XFCkbq8DSmFqzxgV1y5uk+DxI+orL9Y04lQ7vn2ZHyYlCvBw8P re+MjztCWE7Qr4Ohkb8+xoXZPsfZqyz/JICOUqUotKPzOW2ldATrsD0WK4+UyYJ8SWzIc0vp uIFZIRNDSaNykYsS+V2miF+3lL+qj9zEgF792uqEuE7GtRGsdd0zs=
  • Ironport-sdr: rFvlZII930Li9SFz08UVjIbWq37B2498gvA2o+J2dZpE8hGb9gsJdpvPmNbd5YEb0rPuXQBMTS Yln1bCYRb/tb+eHXUGH59+75rOFGw8k5GAk/3qS79mvujWsT3Tm38T8jY2RSTlrirq3wimSE4q gKw8YRR0T95lMn3Myz1VEFgLp0+m4+ySmTKpGBeVUjjQy+slqIEdweJdvVSRgtldlPGIOKg2Tf YqpfX/hp140NdN8JmS1bFIikN1IWA5ZEnFNNGHCjDsyUN+V1lt8LSX5cgBI4EGilYr+lOIjeN6 HQ2KmaIE22IgGfsYElY6vx8z
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHXv0Ea8wbdbS6/Ik+7S9shoWs6iavPBwiA
  • Thread-topic: [PATCH v5 0/3] Expose PMU to the guests



On 12 Oct 2021, at 09:13, Michal Orzel <michal.orzel@xxxxxxx> wrote:

This patch series is a rework of an already pushed patch
exposing PMU to the guests. Since the second version the vpmu
parameter is common and prework in the form of reporting
availability of vPMU on the hardware is added.

The third version of the patch series removes the redundant check
from x86 code and modifies the way to define the flags XEN_DOMCTL_CDF and
XEN_SYSCTL_PHYSCAP, meaning not to define bit position and mask separately.

In the fourth version, the additional check is added so that we fail
if vpmu is set in the config file but XEN_SYSCTL_PHYSCAP_vpmu is not available.

In the fifth version, SUPPORT.md is updated with the information about
vPMU feature and checks for platform PMU support are improved.

The current status is that the PMU registers are not virtualized
and the physical registers are directly accessible when "vpmu"
parameter is enabled in the guest config file. There is no interrupt
support and Xen will not save/restore the register values on context
switches. This is to be done in the future.

Michal Orzel (3):
 xen+tools: Introduce XEN_SYSCTL_PHYSCAP_vpmu
 xen/arm: Check for PMU platform support
 xen: Expose the PMU to the guests

SUPPORT.md                           |  9 +++++
docs/man/xl.cfg.5.pod.in             | 17 ++++++++++
tools/golang/xenlight/helpers.gen.go |  8 +++++
tools/golang/xenlight/types.gen.go   |  2 ++
tools/include/libxl.h                | 12 +++++++
tools/libs/light/libxl.c             |  1 +
tools/libs/light/libxl_create.c      | 10 ++++++
tools/libs/light/libxl_types.idl     |  3 ++
tools/ocaml/libs/xc/xenctrl.ml       |  2 ++
tools/ocaml/libs/xc/xenctrl.mli      |  2 ++
tools/xl/xl_info.c                   |  5 +--
tools/xl/xl_parse.c                  |  2 ++
xen/arch/arm/domain.c                | 13 +++++--
xen/arch/arm/setup.c                 |  3 ++
xen/common/domain.c                  | 12 ++++++-
xen/common/sysctl.c                  |  3 ++
xen/include/asm-arm/cpufeature.h     | 51 ++++++++++++++++++++++++++--
xen/include/asm-arm/domain.h         |  1 +
xen/include/public/domctl.h          |  4 ++-
xen/include/public/sysctl.h          |  6 ++--
xen/include/xen/domain.h             |  2 ++
21 files changed, 157 insertions(+), 11 deletions(-)


2.29.0


Acked-by: Christian Lindig <christian.lindig@xxxxxxxxxx>



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.