Re: [PATCH v5 07/10] libxl: Only map legacy PCI IRQs if they are supported

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Mon, 11 Oct 2021, Anthony PERARD wrote:
> On Fri, Oct 08, 2021 at 08:55:32AM +0300, Oleksandr Andrushchenko wrote:
> > From: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
> > 
> > Arm's PCI passthrough implementation doesn't support legacy interrupts,
> > but MSI/MSI-X. This can be the case for other platforms too.
> > For that reason introduce a new CONFIG_PCI_SUPP_LEGACY_IRQ and add
> > it to the CFLAGS and compile the relevant code in the toolstack only if
> > applicable.
> 
> I don't think that's true anymore since v2 ;-). The compiler may
> choose to avoid compiling code that wouldn't be executed, but I think
> that would just be optimisation.
> 
> > Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
> > Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> > Reviewed-by: Rahul Singh <rahul.singh@xxxxxxx>
> > Tested-by: Rahul Singh <rahul.singh@xxxxxxx>
> > ---
> > diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile
> > index 7d8c51d49242..bd3f6be2a183 100644
> > --- a/tools/libs/light/Makefile
> > +++ b/tools/libs/light/Makefile
> > @@ -46,6 +46,10 @@ CFLAGS += -Wno-format-zero-length -Wmissing-declarations 
> > \
> >     -Wno-declaration-after-statement -Wformat-nonliteral
> >  CFLAGS += -I.
> >  
> > +ifeq ($(CONFIG_X86),y)
> > +CFLAGS += -DCONFIG_PCI_SUPP_LEGACY_IRQ
> > +endif
> > +
> 
> Could you write this instead:
>   CFLAGS-$(CONFIG_X86) += -DCONFIG_PCI_SUPP_LEGACY_IRQ
> 
> In any case,
> Acked-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Thanks Anthony! I made this change on commit and committed both this
patch and the previous one.