[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH v7 22/51] build: clean common temporary files from root makefile


  • To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 11 Oct 2021 13:41:16 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xrGr5wVVaHopp7AoYHAPc1PIODhQq+mvSjO27YeVW4w=; b=oBZRSENxWDkjr6tJMQAUFOGx7bql7a/49qqZmnyqdW2cMlL5hxHwD7a/imnTQ3KP+WsL0vB0o/mmjD+ynwRudawRM3kYFBzJ7KX1YdwrqL8hN9odlerGYYoI/BiwC8Eo0Xg5RCet2gL8K9oFLDawbILZFQOHbCtZ7OcFZx0C81gXYhS99XEajOZ12nVX87ipg9sIguOB/nI9yvKjhc3KvC+Iwb2yxv/6kfhLnFkE7oEV9Zdoq7i/AmgIjaaGhmULQxrX/8oiRdJ3D3419ewOx3bhjvEICLANi4bh8aYS8bTsjafVHVyOCRcoaldeqvT0NXwg2ql0ikyCCMHmTp+Dvg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oOCYe4s1aoq37XUOepo1tZKyiNuaDXCPgHRZGFA4ksRXF/3RCvw6a2RrrApzYguFVldroGGegLdC23ZiFc8EZ3QtBM+N4bB9TRS/dyzXBWPdsJRLGjVC31ALug+87dtei8Pbr6KGjuulLnJ9cAcRAmjAF+ab/tSakU4k7sd3MoH39qTbCp2Llk39cXhc6NRsUWMtyP/NP86eI8ZQcIwXFQGI+Qy5EEs5jmRUcn107NVen5vtLpc17mEYWCLpapTOz74kg1CpjsxgqWpnhTqbLs7T3Wc4XFpQjTjvH8wdoS8JuL5ZJWeMzsEomk93T5aWhr6bU9ingNS5xoWuKvrOVQ==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Mon, 11 Oct 2021 11:41:35 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 24.08.2021 12:50, Anthony PERARD wrote:
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Trying to synthesize a description:

> --- a/xen/Makefile
> +++ b/xen/Makefile
> @@ -382,6 +382,7 @@ _clean:
>       $(MAKE) $(clean) test
>       $(MAKE) $(kconfig) clean
>       find . \( -name "*.o" -o -name ".*.d" -o -name ".*.d2" \

This was effectively redundant with ...

> +             -o -name ".*.o.tmp" -o -name "*~" -o -name "core" \
>               -o -name "*.gcno" -o -name ".*.cmd" -o -name "lib.a" \) -exec 
> rm -f {} \;
>       rm -f include/asm $(TARGET) $(TARGET).gz $(TARGET).efi 
> $(TARGET).efi.map $(TARGET)-syms $(TARGET)-syms.map *~ core
>       rm -f asm-offsets.s arch/*/include/asm/asm-offsets.h
> diff --git a/xen/scripts/Makefile.clean b/xen/scripts/Makefile.clean
> index 027c200c0efc..b6df9e861e6e 100644
> --- a/xen/scripts/Makefile.clean
> +++ b/xen/scripts/Makefile.clean
> @@ -14,10 +14,8 @@ include Makefile
>  subdir-all := $(subdir-y) $(subdir-n) $(subdir-) \
>                $(patsubst %/,%, $(filter %/, $(obj-y) $(obj-n) $(obj-)))
>  
> -DEPS_RM = $(DEPS) $(DEPS_INCLUDE)

... this and its use below.

>  .PHONY: clean
>  clean:: $(subdir-all)
> -     rm -f *.o .*.o.tmp *~ core $(DEPS_RM)

With the command gone, I think the :: should also be converted (back) to
just : then. Then
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Assuming the patch is independent of the earlier still uncommitted ones
(please confirm), I'd be happy to make the adjustment while committing
- as long as you agree, of course.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.