[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag


  • To: Rahul Singh <rahul.singh@xxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Mon, 11 Oct 2021 11:27:30 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Nhj/9AQhuHyYoJKw232vgX+Cae7CgjeZ5eEe36J1kyI=; b=Gr1F/dOvB5ma6UTPNWlADO9cHK3bWWUHA4wCOcMS4s0s60F/3P59G0wyXLCmdav+7SRJ1jRXRzVuvT+4nWlA6QcJhzeElLQ4dpvIfx/Zf9vxkv2AkDzuAk+ykrN6JOaGHWQ/LMXQw9comQTplE8EWOGEZn0ZKAWotL2rDxUOWyiNq4Vt7AIT33D8oUM9atm0bYCQxPdHBVwYwMm5yRO1z+Gha4nWFIz62Tgj0weinHvDwlJdPsJdEQ2qzmKhv7RTuBDHHcsm8HEKnlLJGCZw3QgUMcY826LxquWpFxSi4mBGKbQglMDRzuETkUchtWFWr9Zed08cpDFJxzHJao4RDQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ct/Ri8oX2ouVMKcOo+dGyhQO8m6CQbOHszG+fBs5Bl126SEOcQn2/8bgdKAB6NE2rqeCYv7Mz9l6oP0Uils/I2vVo8De5N47ChRkZTncUvi1WmorSbXxM8ibsc1ouOsi7d8F8yvP2BWcHJlWVf6akYnQDXD/t1GoX58JV8WBd7fC7SsMrsjuBGFtwlJfPRbX9aQslhl5qi08PbQCmsAbo2r07RXhD9qrc+r6QyIFIl9S1IL+nL/WPdC3hIbL0O0V4xgxGuqabxLcOy5jRleIqDX/FokDtH1S4icU4BkkTCZkUhezplQbLPKHbMZqe6/Smy3PXofZ+AKc2phZ5px3ug==
  • Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, <bertrand.marquis@xxxxxxx>, <Andre.Przywara@xxxxxxx>, Christian Lindig <christian.lindig@xxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Mon, 11 Oct 2021 09:27:58 +0000
  • Ironport-data: A9a23:cz786KkqmOTe8uL3xgQqKmLo5gyKIERdPkR7XQ2eYbSJt1+Wr1Gzt xIeUTrXPqnYYmShKNknOdm28EoP757dm9c3HAI4q30zRSMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA185IMsdoUg7wbdg2tcx2YHR7z6l4 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4 MUUio7oTS4VArbFpPoAEAFyOH5QOKITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq 6ZecmpUKEne2aTmm9pXScE17ignBNPsM44F/Glp0BnSDOo8QICFSKLPjTNd9Gps1pEXTKyED yYfQQJjfiWdXTlNAwxUA74Rs+3zxVnYfCIN/Tp5ooJoujOOnWSdyoPFMtDYZ9iLTsV9hVuDq yTN+GGRKg4eHMySz3yC6H3Eru3SmSL2XqoCGbv+8eRl6HWtwWgUBAwTREGMi/CzgU6jWPpSM 0URvCEpqMAa71e3R9PwWxm5pn+svRMGXddUVeog52mly7XWyxaUAHAeSTxMY8Bgs9U5LRQ62 1nMk973CDhHtLyOVWnb5rqStSm1OyUeMSkFfyBsZREM48Tn5poyiB3PZt95Fei+ididMTv92 SyQpS4ywbAal9cW1r6T9ErCxTmro/DhQgcr6y3NU2mi7wc/Y5SqD6SB71TB4LB4NpSIUVCbt VANgc3Y5+cLZaxhjwTUHr9LRuvwoa/YbnuM2jaDAqXN6Ry9okGxJYR53A1lLXt3L4UcUxS2T krc7FY5CIBoAFOmaqp+YoSUAssszLT9GdmNas04fuaicbAqK1fZpHAGiVq4mjm3yhB1wP5X1 YKzKJ70VR4n5bJbIC1argv3+YQgwTwi3ivtTJT/wgXPPVG2NSPNF+lt3LdjaIkEAEK4TOf9r 4Y32yiikUw3vAjCjs//q9N7wbcidylTOHwOg5YLHtNv2yI/cI3bN9ffwKk6Z6tulLlPm+HD8 xmVAxEDkwqu3SKecFnUMRiPjY8Du74k9xrX2gR2bD6VN4ULO97zvM/zibNmFVXYyACT5aEtF KRUEylxKv9OVi7G61wggWrV9+RfmOCQrVvWZUKNOWFnF7Y5HlCh0oK0L2PHqXhVZgLq5JRWn lFV/l6CKXb1b185V5i+hTPG5w7ZgEXxb8orBxGWfYIJJBm1mGWoQgSo5sIKzwg3AUyr7hOR1 hqMAAdeou/IooQv98LOi7zCpICse9aS1GIDd4UCxbrpZyTc4ES5xopMDLSBcTzHDTum86S+f +RFifr7NaRfzlpNtoN9FZdtzL4/uISz9+MLkFw8ESWZdUmvB5NhPmKCgZtFuJpSy+ILogCxQ E+OpIVXYO3bJMP/HVcNDwM5deDfh+oMkzzf4K1tckX37SN65pSdVkBWM0XegSBRNuItYogk3 f0gqIgd7Anm0kgmNdOPjyZ18WWQLyNfD/V7589CWIKy01gl0FBPZ5DYGxTa2pDXZoUeKFQuL x+VmLHG2+ZWyH3dfidhDnPKx+dc28gD4UgY0F8YKl2VsdPZnftrjgZJ+DE6QwkJnBVK1+V/Z jpiO0FvfPjc+j5pgI5IXny2GhEHDxqcoxSjx1wMnWzfbk+pSm2SczFtZbfTpBgUozBGYzxW3 LCE02K0Az/lcfb40jY2RUM4+efoSsZ891Galc2qdyhf80LWvdYxbneSWFc1
  • Ironport-hdrordr: A9a23:TwT7n6AoyQ4zDyjlHeg3sceALOsnbusQ8zAXPh9KJiC9I/b1qy nxppkmPH/P6Qr4WBkb6Le90Y27MAnhHP9OkPIs1NKZMjUO11HYTr2KgbGSpgEIXheOi9K1tp 0QDZSWaueAdGSS5PySiGLTc6dCsai6GeKT9J/jJh9WPH5XgspbnmFE42igYylLrF4sP+tEKH PQ3LsMmxOQPVAsKuirDHgMWObO4/XNiZLdeBYDQzoq8hOHgz+E4KPzV0Hw5GZTbxp/hZMZtU TVmQ3w4auu99m91x/nzmfWq7BbgsHoxNdvDNGFzuIVNjLvoAC1Y5kJYczOgBkF5MWUrHo6mt jFpBkte+x19nPqZ2mw5SDg3gHxuQxeokPK+Bu9uz/OsMb5TDU1B45qnoRCaCbU7EImoZVVzL 9L93jxjesXMTrw2ADGo/TYXRBjkUS55VA4l/QIsnBZWYwCLJdMsI0k+l9PGptoJlO11GkeKp gsMCjg3ocVTbvDBEqp+1WHgebcEUjbJy32AnTr4aeuonxrdHMQ9Tpv+CVQpAZGyHqRI6M0kt gsCZ4Y542mePVmGp6VNN1xMfdfNVa9My4kEFjiaWgPR5t3cE4klfbMkcEIDaeRCdo18Kc=
  • Ironport-sdr: mXnozezTyWv+DfILVbzqTgn1sy9O41k5aOxcWI+eadU8oM1m13WW1NR2HPtZlCNBzhpatpBZjY UvsUZpq9KiXEIpQiqGqho0nxD4OeE6dUrDuV6RUB4MzaNpP8mPLcVJAy4rnbSK+U2Vmm/5P7b+ RXNjBZCCjn7XNAFrmUIsZwPf9tK+32x15xt8D1raVGWdvdFYre8tLhM44uPDTZZL0sMtXvAZ/Z 8LhrGKzuVuz6e5tZA14tw1zop7Bg9AM7fVfojFEdKTiT3NWZ6rvnwL1rt94qPnVvjEKhPADTwz fguc8MsywMV2+k7T+8KZi9lC
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Wed, Oct 06, 2021 at 06:40:33PM +0100, Rahul Singh wrote:
> Introduce XEN_DOMCTL_CDF_vpci flag to enable VPCI support in XEN.
> Reject the use of this new flag for x86 as VPCI is not supported for
> DOMU guests for x86.

I don't like this approach, XEN_DOMCTL_CDF_vpci should be set for x86
PVH dom0, like we do for any other CDF flags when Xen builds dom0.

Things like PVH vs PV get translated into CDF flags by create_dom0,
and processed normally by the sanitise_domain_config logic, vPCI
should be handled that way.

Do you think you could see about fixing this?

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.