[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH V5 1/3] xen/arm: Introduce gpaddr_bits field to struct xen_arch_domainconfig
- To: Oleksandr Tyshchenko <olekstysh@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 7 Oct 2021 09:42:59 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M3JsOkfgsXjB8nNPf3PZ1+oX1U97jEhGbM+4DNGvB6c=; b=VLkHuDO5gfsVrD13i9tob6W8rjWoaAsLG86tpcg3OMyk+dv9iibr9ZlGFrtzOXS8bWzBbYCZEwHOgJ/XT3CbWr7DYNseTVlNhy/rp7s7EDkOGgj97/V4Pal56WULSoIY+Vv/NZRwNlQwBVy1ZpgF/zHF5iJhA/EwDDf1SL+rDw4fKa3+fGV7gDhSKNFOci0mZMvHUqQqku0p5JGRXonYTsctMKKFElTnB8XNajRp0eI1FkGTEAJAnG8lFIAClPRwKf9XJYv+CaZq51F70WcrrX21dZIbZszdX1yu/6xL09LUCq0xMD2YIvYegwUbIGJJ7fLnbCkbWAjCNRhwRAA7DQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z7IRWWgDhM8vsFFoiHmojfB9njI4TSTQcWiyIs8VIeXVnyh4lQLz8CotLQNeutWL8ssv6DixChHdVQq0yPmzhbbbYOVfrGjXhojGM1K7XTCr6sP/TtrAO973Oa1CtvAppWEFcgaVPEH3+qXr+7TSDFRDgnvDdYhn8JGRH0fM3SQ1DwuW21YVkIgA+RqleCosvo8ylmYw/f+k3sanN6db7gf7OfhQ5DiPLRAQpLC+cz6GWRNCTdOxxWsQda2++zAtdEC+DWyHn/oD7i0plVOpq0ZMD2Gv15+pWhnXtxRU92+fwhfIOvjmGot7hVkBajTY1XJ2Fohfdrl2tjgAdCgXvQ==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 07 Oct 2021 07:43:10 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 06.10.2021 13:22, Oleksandr Tyshchenko wrote:
> Changes V4 -> V5:
> - update patch subject and description
> - drop Michal's R-b
> - pass gpaddr_bits via createdomain domctl
> (struct xen_arch_domainconfig)
I'm afraid I can't bring this in line with ...
> --- a/xen/include/public/arch-arm.h
> +++ b/xen/include/public/arch-arm.h
> @@ -333,6 +333,11 @@ struct xen_arch_domainconfig {
> *
> */
> uint32_t clock_frequency;
> + /*
> + * OUT
> + * Guest physical address space size
> + */
> + uint8_t gpaddr_bits;
... this being an OUT field. Is this really what Andrew had asked for?
I would have expected the entire struct to be IN (and the comment at
the top of the containing struct in public/domctl.h also suggests so,
i.e. your new field renders that comment stale). gic_version being
IN/OUT is already somewhat in conflict ... One of the problems with
_any_ of the fields being OUT is that then it is unclear how the output
is intended to be propagated to consumers other than the entity
creating the domain.
Jan
|
