[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in libxl
- To: Ian Jackson <iwj@xxxxxxxxxxxxxx>
- From: Rahul Singh <Rahul.Singh@xxxxxxx>
- Date: Wed, 6 Oct 2021 11:17:44 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M2PqoS9qf64W0dvbW9fTe7iTB30jPr0hswKZyn0Nll0=; b=BvT2MTyXlFmKW2w41fyTJwPb+IFicdyIUeIqJSz/1wXX5qBuDvgg8kUnhZ+us1yCNZiJjgWY+jBMsYikLOfCYttg/oeHRlnvJhOpw/4ssTK+b+iBEr/DOo3ubbofmvrIVi8cyNwYucAWQ05txJ0eOVriy9EqBreyzQ1xRCee6/k0g8TwcbkCguA/M9cGFQbuFzz5ATVNUWrVt3pouLk7wzLqXoXNgsPsfFQyIUOt4nwzE1Rc5hCw5fJbsh38AuReMv2yy71MSFHasUV8EM2yp6g+233hg2z4T4hiKAE4ruhPJsBBdOcoGVdNA9jSZrh6a3HA2JmGCtqCNxFm7yeUJA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cs7W92OOtQQHtBAD7Nv0dii6hB5AXAEjY0XeoT8UxeeDGJ5dFip2v+A53kmFsfziPJ+mL7LrBPN2oT8Xf/WxRYV8EcqWeYSUENO9ksxmF5yHcrJiuiV0YxSRMJbNG/Tt814BmZlfEiUecZD+BjpRCVlOdhCnyeP9k4PSre8MF+r3yA4U0eK+t5V2tz8eFiMzYIgKRzGIV+bZYR+xUwpaPXabxYlK+AdMPRiYgrQkRilfPhuvnOWmsvpWYL0y87NU7g5pLok1sy/aX9C13Jun5ryTB2cz7xWZAz+RHRtvtFHJxwRff41Kh3e4VBjLumXsnhEjfF8pncDxnZ9o4Fj3Jw==
- Authentication-results-original: xenproject.org; dkim=none (message not signed) header.d=none;xenproject.org; dmarc=none action=none header.from=arm.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Andre Przywara <Andre.Przywara@xxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Wed, 06 Oct 2021 11:18:04 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: xenproject.org; dkim=none (message not signed) header.d=none;xenproject.org; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHXuRciClWhjFX7R0aQhsW/aixhyqvDkJEAgACf3oCAAL5hgIAAzJaAgAAXDgCAAALtgA==
- Thread-topic: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in libxl
Hi Ian
> On 6 Oct 2021, at 12:07 pm, Ian Jackson <iwj@xxxxxxxxxxxxxx> wrote:
>
> Rahul Singh writes ("Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree
> node in libxl"):
>> libxl_defbool_val(libxl_defbool db) is implemented in such a way that it
>> will assert
>> if db value is the default. Therefore we have to explicitly set it to
>> LIBXL__DEFBOOL_FALSE for x86.
>>
>> There are two option either we can have #ifdef or we can move the
>> libxl_defbool_setdefault(&b_info->arch_arm.vpci, false) to common code.
>
> What is wrong with putting it in
> libxl__arch_domain_build_info_setdefault
> which I think exists precisely for this kind of thing ?
As we have to set the arch_arm.vpci to false for x86 and ARM I thought it is
right to move the code to
common code to avoid duplication.
Are you suggesting to put " libxl_defbool_setdefault(&b_info->arch_arm.vpci,
false)”in
libxl__arch_domain_build_info_setdefault() for x86 and ARM differently.
Regards,
Rahul
>
> Ian.
|
