[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 06/11] xen/domain: Call pci_release_devices() when releasing domain resources
- To: Oleksandr Andrushchenko <andr2000@xxxxxxxxx>
- From: Rahul Singh <Rahul.Singh@xxxxxxx>
- Date: Wed, 6 Oct 2021 10:35:23 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FFfEkXibDGx+sdiXSgcsc4LfpmLdbfaAPug/eDcPprc=; b=YyrlESHjbd2skXqguEHFq5wQus4lAvxEgBWqvh0hQ3HGK0QaffQJze0PKYCuG2eqwzgppLgMe3WrRDqMjyfWAtDkctlJBXjjnBHr03aT94U5lIViYAPvavSpxkJOAhqN5yUS5tLAqwX7BsPySZmS19H9X9ZE8MafP70OpkiNtsaRJ+FjFoD2PP1fD1bp4CXZ4dIs3ShEN97rf0Fov3rfdN8S6Be8sestnIjDBN+eajcZovzrcSarbcwnvG/A/WOmJGHGDtEiS57y5dR19HLh1hkcdpIBb4e8+dtSmqtH76CSoZcUp0FikWP58FyKjmm/vc6+ruXLoMPfY0SlBdnusg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TCoQyFs7IyiUO1+K3cmJ+SezymTPkrXMEayN+Qg9+m29k0o5SU3mSsy32kF9i99qkKyNiYGZBJkpXrhSNyNGliMBm4JyQ8JfIxlJbwfIx6Rym8BHg41lS6zzu3JZsz9VyJHW/HCTB1xmBh1GpXuy5kV3Ce2WHD0uT1yOW+s3qGzM1YnrO3Lb363oXp3kUxUEWg5jLIJzTg5nD2Yr878uR8mnBxHaOtnXfO1kcwWJxYry7+ZnStNjyOkiEdo+A8HGGfQjDGwIz/ZNCgnGOp2qXyARYj74wiHRXmXSudwTxY3+mZm5GGv9WkcuAWdPPyXYBkWkazU2b1YUc04IgCA7IQ==
- Authentication-results-original: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=arm.com;
- Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "oleksandr_tyshchenko@xxxxxxxx" <oleksandr_tyshchenko@xxxxxxxx>, "volodymyr_babchuk@xxxxxxxx" <volodymyr_babchuk@xxxxxxxx>, "Artem_Mygaiev@xxxxxxxx" <Artem_Mygaiev@xxxxxxxx>, "roger.pau@xxxxxxxxxx" <roger.pau@xxxxxxxxxx>, "jbeulich@xxxxxxxx" <jbeulich@xxxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>, "george.dunlap@xxxxxxxxxx" <george.dunlap@xxxxxxxxxx>, "paul@xxxxxxx" <paul@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
- Delivery-date: Wed, 06 Oct 2021 10:35:44 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHXuSnWj8Dry4hpBkuVdc9SAVWBMqvFyWiA
- Thread-topic: [PATCH v4 06/11] xen/domain: Call pci_release_devices() when releasing domain resources
Hi Oleksandr,
> On 4 Oct 2021, at 3:11 pm, Oleksandr Andrushchenko <andr2000@xxxxxxxxx> wrote:
>
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
>
> This is the very same that we already do for DT devices. Moreover, x86
> already calls pci_release_devices().
>
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
Reviewed-by: Rahul Singh <rahul.singh@xxxxxxx>
Tested-by: Rahul Singh <rahul.singh@xxxxxxx>
Regards,
Rahul
> ---
> Since v1:
> - re-wording in the commit message
> ---
> xen/arch/arm/domain.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> index fbb52f78f1a6..79012bf77757 100644
> --- a/xen/arch/arm/domain.c
> +++ b/xen/arch/arm/domain.c
> @@ -985,7 +985,8 @@ static int relinquish_memory(struct domain *d, struct
> page_list_head *list)
> * function which may return -ERESTART.
> */
> enum {
> - PROG_tee = 1,
> + PROG_pci = 1,
> + PROG_tee,
> PROG_xen,
> PROG_page,
> PROG_mapping,
> @@ -1022,6 +1023,12 @@ int domain_relinquish_resources(struct domain *d)
> #ifdef CONFIG_IOREQ_SERVER
> ioreq_server_destroy_all(d);
> #endif
> +#ifdef CONFIG_HAS_PCI
> + PROGRESS(pci):
> + ret = pci_release_devices(d);
> + if ( ret )
> + return ret;
> +#endif
>
> PROGRESS(tee):
> ret = tee_relinquish_resources(d);
> --
> 2.25.1
>
|
