[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 07/11] libxl: Allow removing PCI devices for all types of domains
- To: Oleksandr Andrushchenko <andr2000@xxxxxxxxx>
- From: Rahul Singh <Rahul.Singh@xxxxxxx>
- Date: Wed, 6 Oct 2021 10:25:22 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ae3FB2rpyT/4lXZBaiyLZGMGbJpTMT8SoEC62EmGOYE=; b=kpbNkb1leFYUODLWOCFyQoKqvzNWtD83cder6F06y7Xjdrd1r7HPWxIwjPJxJLXYOrd8XGC2PpXS1I37yIAuzYVNc2a9S1DJtjUHm/74qvWKa4f0s1ZdjdyJKuZ+N/+egE0XcAPH2Lvri/7Qt8PNQzv8LBC1tn6p1+myYTVyjTl6gSZYYCa5lDz2c6ZKco1iIk9KzlMgQZy3CP19QMs2tuzMbaxrm2PjfYacyqCeX4e10xwxOO1Ggz0wfEHNzyraSoa7cZ7LSeS1ivVLSVA2xjSBrP9flJT+RBzSDbclUjvh8KymeFpqeMfwfeegBz82PZjXmSDCSYYa2kQExrnpBA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FyQe2kOZGRf45ZnJkJXDOXE+HL1X1qqe/qFNYHYMxOLQ2+0KTOxCDdEIMEdcnlfssAHHzioRGQqIbMa4+1x18M2oOezhyLESiP+HNVPYOpxzlCBqNGYaLoKfCoeZ/dCv3ThH8HmCSGMMgOAKa/gyJzhvTZI2X7pWu6Fgpj8w57p0mTIUUhfq9W2BQDjnvYq9CkF2t1OWMwlB/MICmbW0oQcLiYL7QT8R1bema8Q/bfE5FX5OZAmVBQhI8UP7Ufj95Toc8W6xynauE6GZ9Wv4PC5sF8v88B3uSdagSXk0TWLSCAmWyi19xisTikE4K9Ds+0Ew5Inex4lwpjViB5myPg==
- Authentication-results-original: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=arm.com;
- Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "oleksandr_tyshchenko@xxxxxxxx" <oleksandr_tyshchenko@xxxxxxxx>, "volodymyr_babchuk@xxxxxxxx" <volodymyr_babchuk@xxxxxxxx>, Artem Mygaiev <Artem_Mygaiev@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, "paul@xxxxxxx" <paul@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
- Delivery-date: Wed, 06 Oct 2021 10:25:42 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHXuSndFv+e6OSIekuaKFO6u9L6m6vFxpwA
- Thread-topic: [PATCH v4 07/11] libxl: Allow removing PCI devices for all types of domains
Hi Oleksandr,
> On 4 Oct 2021, at 3:11 pm, Oleksandr Andrushchenko <andr2000@xxxxxxxxx> wrote:
>
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
>
> The PCI device remove path may now be used by PVH on ARM, so the
> assert is no longer valid.
>
> Cc: Ian Jackson <iwj@xxxxxxxxxxxxxx>
> Cc: Juergen Gross <jgross@xxxxxxxx>
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
> Acked-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
Reviewed-by: Rahul Singh <rahul.singh@xxxxxxx>
Tested-by: Rahul Singh <rahul.singh@xxxxxxx>
Regards,
Rahul
> ---
> tools/libs/light/libxl_pci.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/tools/libs/light/libxl_pci.c b/tools/libs/light/libxl_pci.c
> index 1a1c2630803b..59f3686fc85e 100644
> --- a/tools/libs/light/libxl_pci.c
> +++ b/tools/libs/light/libxl_pci.c
> @@ -1947,8 +1947,6 @@ static void do_pci_remove(libxl__egc *egc,
> pci_remove_state *prs)
> goto out_fail;
> }
> } else {
> - assert(type == LIBXL_DOMAIN_TYPE_PV);
> -
> char *sysfs_path = GCSPRINTF(SYSFS_PCI_DEV"/"PCI_BDF"/resource",
> pci->domain,
> pci->bus, pci->dev, pci->func);
> FILE *f = fopen(sysfs_path, "r");
> --
> 2.25.1
>
|
