[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 03/14] xen/arm: Add PHYSDEVOP_pci_device_(*add/remove) support for ARM
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: Julien Grall <julien.grall.oss@xxxxxxxxx>
- Date: Tue, 5 Oct 2021 09:52:24 +0200
- Cc: Rahul Singh <rahul.singh@xxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Andre Przywara <Andre.Przywara@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Tue, 05 Oct 2021 07:52:43 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Given that only ARM needs the !CONFIG_HAS_PCI stub, I would add it
directly to xen/arch/arm/physdev.c. Or just add an #ifdef directly
within do_physdev_op in xen/arch/arm/physdev.c.
If we want to keep the stub, then it should be the generic code so it can be used by other arch in the future.
That said, I would also be happy with the #ifdef directly in do_physdev_op.
|
