[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH 2/2] automation: Add qemu to debian:stretch container for smoke test


  • To: Anthony PERARD <anthony.perard@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Thu, 30 Sep 2021 18:05:44 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=dc5vJBu+ChwdTu9pieDDIJmA6hfIZVGwJLJVkIwSfP8=; b=ltJXTZSyPXT2r/32vSA6XJ805I83BylQnBzL32KWhRYrJeU0qhNfcLb8YAvVSoF5Vcv14A9c+nQy0QVYpLrteZAqnCZCIOx9K2Q8qBXCAVjGEN8JxAOzmvZYZHWUxabqCoTrCyMGeWdhBbhB+VUpu3BHdqPIrLfx/IlePIqTir6N6dR1mYN3ZUSyJe4p8UgeTahB3VTSusfCYJEry9e0tgo3N8C9KtmSZ01EMaeB5LCl7ohdQmFGsuZrKW6v4sTUxkqKFpWHn3rYjWJCqEbpPn/UDL35kKgnEPDF+g02QKkraMZxXWHjvh/ucGHXgJASgoTseiTQxji+rOrtcfd4dA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l5kDTGUJDrWhdruXxm7PH8q5TKKwZSEqautSwi+axyRiTK5K75NhqUuQ++QeVa3xKNPrqL76Qh+WtPP4hCdy+236XFpZqGv5TiOfc+7UG0VMe29KB2GTXShPvVFHMZ1k8rfgDHedtpJvxzinv3wiNcPqYTYF8hJ3cBm7wWuEBBmRGb1pAaXI5lODvob4lW7+/9IDt7NqM1B3Bxg6Que+L/DQ5uXOHYzP4o/iCZdB+7AIZQv9/DIUuZWAfMoQAjOpm0jwXgj0O65S/BFK+PbA4bleXkBOnOQsIUOZJEdDAlJ9OOVeUm54+dM0NdCm3PZjn46Z7RgKwhcJKKNS2mUvuA==
  • Authentication-results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Anthony PERARD <anthony.perard@xxxxxxxxx>, Doug Goldstein <cardoe@xxxxxxxxxx>
  • Delivery-date: Thu, 30 Sep 2021 17:06:27 +0000
  • Ironport-data: A9a23:5Wsy36xSWmkHPsQRVA96t+fCwSrEfRIJ4+MujC+fZmUNrF6WrkUCx jAcUGDXa/veYGf3L41zPNzk8UgO7JHdydI1T1ZsrCAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAsLeNYYH1500s7yrVh2tQAbeWRWGthh /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt8B/7 o1Pq52dcgYWOvz3vs4sbEMfPwgraMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr 6ZBbmlQMFbT3Ipaw5riIgVoru0lINPmI8U0vXZ4wCuCJf0nXYrCU+PB4towMDIY25wWQa+HP JZxhTxHNgiYfyNePw8rT6lhuuCj1l7kb2VDpwfAzUYwyzeKl1EguFT3C/LFd9rPSchLk0Kwo mPd43+/EhwcLMaYyzeO7jSrnOCntSr9RIIVEqz+7vNwiUef7mMWARwSE1C8pJGRgUekV9VSA 0cd4CYpoO4580nDczXmd0Tm+jje5EdaAocOVb1hgO2Q9kbKyxaXIDAGUD9sU90ZsJ4NYxYb6 QXOs/q8UFSDr4apYX6a876Vqxa7Ni4UMXIOaEc4cOcV3zXwiNtt102eF76PBIbw3oWsRm2gq 9yfhHJm74j/m/LnwElSEbrvrTW2utDtRxM56x/bV2aohu+STNX+PNT5gbQ3AOwpEWp4crVjl CRZ8yR9xLpXZX1oqMBraL5WdF1Oz6zYWAAweXY1Q/EcG82FohZPh7x47jBkP1tOOc0ZYzLva 0K7kVoPv8UCYCP7PfMpMt3Z5yEWIU7ITo+Nuhf8NIcmX3SMXFXfoHEGibC4hQgBb3TAYYlgY MzGIK5A/F4RCLh9zSreegvu+eRD+8zK/kuKHcqT503+idK2PSfJIZ9YYArmRr1ot8us/VSKm +uzwuPXkn2zpsWlOXKJmWPSRHhXRUUG6Wfe8ZcKKbLTflQ8SAnMyZb5mNscRmCspIwM/s/g9 XChQE5Ijl35gHzMMwKRbX5/LrjoWP5CQbgTbETA5H6khCouZ5iB9qAae8dldLUr7rU7n/V1U +MEa4OLBfEWEmbL/DEUbJ/cqo1+dUv02VLSbnT9ODVvLYR9QwHp+8P/ele9/ic5ESfq59A1p Ket112HTMNbFRhiFsvfdNmm00i14SoGgOt3UkaReotTdUzg/ZJEMSv0ivNrccgAJQ+anmmR1 hqMAAderu7I+tdn/N7MjKGCjoGoD+ohQRYKQziFte67bHCI8HCizIlMVPezUQrcDG6kqr+/Y eh1zu3nNKFVllh9rIchQa1gyrgz5oWzquYCnBhkBnjCc3+iFqhkfiudxcBKu6BAmu1ZtA+xV h7d89VWI+zUasbsEVpXLws5dOWTk/oTn2CKv/gyJUz74g5x/aaGDhoOb0Xd1nQFIesnKp4hz McgpNUSul62hRcdO9qbijxZqjaXJXsaXqR77pwXDecHUObwJo2utXAENhLL3Q==
  • Ironport-hdrordr: A9a23:1tj8Dqwdu8rnOEfixq8UKrPwIr1zdoMgy1knxilNoH1uHvBw8v rEoB1173DJYVoqNk3I++rhBEDwexLhHPdOiOF6UItKNzOW21dAQrsSiLfK8nnNHDD/6/4Y9Y oISdkbNDQoNykZsfrH
  • Ironport-sdr: mpr9c8JZGpMpJkG2E2hV5Zv1IcML4QW7Qjy2IXalcjoCaWyneFQpcZTx/Qvzv70UIcieTE6IzQ +nu5PFm3jcqSlhxldqEgDUpxKe5DFkzFa+RU3SYICzY5N5IhypUZPOAgTJtEtDdyF2iWd44ohe zPzYSBXa+LN5T1P97ONnVQDTz+iP4YjTdKxxMSsq2mNJVBWSOzN/jCKmna7D8bZbH+9wso2URy s2an3sWgtafNLjbe7DjNqjxhzC/tkM9lOd1vfZ4p75UwT0tfeanVdKeZIyRh7yllDXRmDFLpOx zxK3PzJzjG5RjKQinJwjOkNd
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 30/09/2021 17:17, Anthony PERARD wrote:
> From: Anthony PERARD <anthony.perard@xxxxxxxxx>
>
> We can add qemu into the container so that there's no need to install
> it everytime we run a test.
>
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> ---
>
> Also, smoke tests stopped working as of today due to outdated
> root certificate, so container needs to be updated anyway.
>     fatal: unable to access 'https://xenbits.xen.org/git-http/xtf.git/': 
> server certificate verification failed.
>
> I haven't push the container yet, I've only pushed it as
> debian:tmp-stretch for testing it.
> ---
>  automation/build/debian/stretch.dockerfile | 2 ++
>  automation/scripts/qemu-smoke-x86-64.sh    | 8 +++++---
>  2 files changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/automation/build/debian/stretch.dockerfile 
> b/automation/build/debian/stretch.dockerfile
> index e2ee14e2017c..da6aa874dd70 100644
> --- a/automation/build/debian/stretch.dockerfile
> +++ b/automation/build/debian/stretch.dockerfile
> @@ -47,6 +47,8 @@ RUN apt-get update && \
>          nasm \
>          gnupg \
>          apt-transport-https \
> +        # for test phase, qemu-smoke-* jobs
> +        qemu-system-x86 \
>          && \
>          apt-get autoremove -y && \
>          apt-get clean && \
> diff --git a/automation/scripts/qemu-smoke-x86-64.sh 
> b/automation/scripts/qemu-smoke-x86-64.sh
> index 4b176c508dec..8ac065491c75 100755
> --- a/automation/scripts/qemu-smoke-x86-64.sh
> +++ b/automation/scripts/qemu-smoke-x86-64.sh
> @@ -6,9 +6,11 @@ set -ex
>  variant=$1
>  
>  # Install QEMU
> -export DEBIAN_FRONTENT=noninteractive
> -apt-get -qy update
> -apt-get -qy install qemu-system-x86
> +if ! type qemu-system-x86_64; then
> +    export DEBIAN_FRONTENT=noninteractive
> +    apt-get -qy update
> +    apt-get -qy install qemu-system-x86
> +fi

I'd just delete this all.  It's wrong for running smoke tests in other
containers anyway.

Can fix commit too.

~Andrew

>  
>  # Clone and build XTF
>  git clone https://xenbits.xen.org/git-http/xtf.git





 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.