[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 1/3] include/public: add possible status values to usbif.h


  • To: Juergen Gross <jgross@xxxxxxxx>
  • From: Luca Fancellu <luca.fancellu@xxxxxxx>
  • Date: Thu, 30 Sep 2021 17:09:02 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=DfvFlHQbUs9B4O1IsuZ2sz6yZd7cM0C64X4xZDlnGJM=; b=PjUJFpeK9HG0aagrvYz5rY2/2G2s7ggLn8hToAbKLVGw/XaricYQh2rBg+27w7iqhQbb1nNwS9Zml5q0h74QepgBVWtyzjQmqilPkaLpze0g1FKyPg4BZoiMzP3RQQXSA38h8JvWwkSKFQLOwElR33iKESBCZe/0xT8PzZ3C0o2HeTM6kiPSXQ0db+qLnFyKHGanmV8tgw48HEkGsPMXgKZPNVY2/OUEQrk8G/zervzx9sv7T15OWogV3ekfXziRTDP5XvYx9/lVLQ8+nWwFpHrASigNC1yWHOrDEngyxEUxDPWzyP3BppuFMki/2K+EX6ofXbU+r4faPsu9DSwrBQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=facK5Jhf0mhGT7N+saymLPcHeo4Nn84HnE4eTaZXpTXKt9Zjs3crEHAZnmczwgTMVAHk+VDEKSAo90S80MMyIm10mZczdae/BuEpMBBVjoKFnVuWTB6haECMItp5VoUSuX1wCNWwR3Wo0t/hEnWJ0giHe00TZ5+F28XFnL1Aahm+UOlRsSh4HYyEoLznfFIv3YbVsFjdzgbCncnVklcqPhksxgs/7hdPylxHaXCwsaU6/fEmTaKyJ6c3KnX7fxZmLor4c4HH+NG40uKoeZ2fhBsPOaqqyl9WCUjt1USVcfH8g4vCtZl+JflDninh0URU7HJZ77wQYsSE5+5abOpWhQ==
  • Authentication-results-original: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Thu, 30 Sep 2021 16:09:30 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;


> On 29 Sep 2021, at 08:46, Juergen Gross <jgross@xxxxxxxx> wrote:
> 
> The interface definition of PV USB devices is lacking the specification
> of possible values of the status field in a response. Those are
> negative errno values as used in Linux, so they might differ in other
> OS's. Specify them via appropriate defines.
> 
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>

Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>

> ---
> V2:
> - add parentheses to macro values (Jan Beulich)
> ---
> xen/include/public/io/usbif.h | 7 +++++++
> 1 file changed, 7 insertions(+)
> 
> diff --git a/xen/include/public/io/usbif.h b/xen/include/public/io/usbif.h
> index c6a58639d6..96b9fb661d 100644
> --- a/xen/include/public/io/usbif.h
> +++ b/xen/include/public/io/usbif.h
> @@ -221,6 +221,13 @@ struct usbif_urb_response {
>       uint16_t id; /* request id */
>       uint16_t start_frame;  /* start frame (ISO) */
>       int32_t status; /* status (non-ISO) */
> +#define USBIF_STATUS_OK              0
> +#define USBIF_STATUS_NODEV   (-19)
> +#define USBIF_STATUS_INVAL   (-22)
> +#define USBIF_STATUS_STALL   (-32)
> +#define USBIF_STATUS_IOERROR (-71)
> +#define USBIF_STATUS_BABBLE  (-75)
> +#define USBIF_STATUS_SHUTDOWN        (-108)
>       int32_t actual_length; /* actual transfer length */
>       int32_t error_count; /* number of ISO errors */
> };
> -- 
> 2.26.2
> 
> 




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.