[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 11/11] xen/arm: Translate virtual PCI bus topology for guests
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
- Date: Thu, 30 Sep 2021 09:35:49 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=2uuNPe+aR9cXUgQhOz+22Lww5ecJCpAhQ1R6sKi28MM=; b=AJMylZU9Kk5FY/fw8/KPMBdx7fvmBzEFrUbzxU98+PiELg+jof7OfUGLDNW9O2Ry7/9eDg1WWnN/Y/x8ooh+cin/jt7mqpMBwVgx3kMnjAKsw7Wss8B40o2zW9ETh6WmotP9Lainiaj0RLjdBfw9NNIYAdveNYH/FpF6rpUr4EeInUpIimNeXjdjIBk5MvfGk7WvwvetpeLmdON/zg3njDRVq/Ou7GQJztfBIYCpg8+oM7tD5vli7vU4yNXuHfgmJ4UZQ2etUpKL3Hzrqs8M3meYYnghxgUKxFpaLdvKEAdr2OIFXOOHEKtRo7UnDoDjSDyndrNkK8PLt65zi2n/HQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Oih6JFIp34hv5EaeL0o3//CggnhNRh9qYvnIbcHckTOVWS/X1ErcZbsNmKhmOTqYRJFiRvWLH15OlPVOgQgay8ZSEDoOWeEyL6DCGIfryxhlDCi4TUfDUgqTkDcVcuRw6/hSzgUOsv7U3Ke9SfLYCiDzMH+/F2wxPzviRLOkFhWdvYMDnaxP1J6ma2cwq3TQNJHXubFAapSxvOPzm0nbTclZxLXEp2aXQ1xCijLuxRc1RvH2jrPeSOhKJBpND5Qo28ddtrQBfLp7wl47A4jk6qdMO2n1o/42nwRbCSxIiZYhmObZE+4tUtc9/Jm6ZhoPjrYFuyJ6ATI3jpjKg7+NWg==
- Authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=epam.com;
- Cc: "julien@xxxxxxx" <julien@xxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Artem Mygaiev <Artem_Mygaiev@xxxxxxxx>, "roger.pau@xxxxxxxxxx" <roger.pau@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>, Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 30 Sep 2021 09:35:56 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHXtdAlBwDHpaYUBUq6q0PlsxoTp6u8Ra2AgAALzYA=
- Thread-topic: [PATCH v3 11/11] xen/arm: Translate virtual PCI bus topology for guests
On 30.09.21 11:53, Jan Beulich wrote:
> On 30.09.2021 09:52, Oleksandr Andrushchenko wrote:
>> --- a/xen/drivers/passthrough/pci.c
>> +++ b/xen/drivers/passthrough/pci.c
>> @@ -889,6 +889,31 @@ int pci_remove_virtual_device(struct domain *d, const
>> struct pci_dev *pdev)
>> xfree(vdev);
>> return 0;
>> }
>> +
>> +/*
>> + * Find the physical device which is mapped to the virtual device
>> + * and translate virtual SBDF to the physical one.
>> + */
>> +bool pci_translate_virtual_device(const struct domain *d, pci_sbdf_t *sbdf)
>> +{
>> + struct vpci_dev *vdev;
> const (afaict)
Ok
>
>> + bool found = false;
>> +
>> + pcidevs_lock();
>> + list_for_each_entry ( vdev, &d->vdev_list, list )
>> + {
>> + if ( vdev->sbdf.sbdf == sbdf->sbdf )
>> + {
>> + /* Replace virtual SBDF with the physical one. */
>> + *sbdf = vdev->pdev->sbdf;
>> + found = true;
>> + break;
>> + }
>> + }
>> + pcidevs_unlock();
> As per the comments on the earlier patch, locking as well as placement
> may need reconsidering.
Other then that do you have other comments on this?
>
> Jan
>
Thank you,
Oleksandr
|
