[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 10/11] vpci: Add initial support for virtual PCI bus topology
- To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 29 Sep 2021 14:54:42 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=R/QiLLZSov1Cp8mTGsC2wZm/hqDv/QWpizr2+S/QJ4U=; b=TVf5Dg5uiWtRKtoxd9OkEhiCr3avl+p6llWQPo0zuNkgxlsmqO9qDEouabnuN+vnCE9mbWCuNO8G6RbANnRr+5wm871NVy3imJq7QIsNymeKcs9avWmoSJw6U5cnZ0MTjoNFrzG8/GJcFpV1JDzeo/89L5jL7yHz5tTExbo2YubHeYlT3boaUheeEt2wWUZ5TiNew9WDRQPs7AxklcBltvEc/7oo+y0BKryPuIseZThlIXQNSsQcNX9qQpqO8pyhHx39cvUDeEMHcxvrHgreYbQNOz6XjfXDbKqZ/ZZYEd3qFtvl9zHCSW4z637uHO58d41FP6d8v0iav9cMmr9hxA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U6Bwsd/mSFzMf7ppUv81MDqILPDrz/JiRpfZfNA/bKJlEn3gLKLLM3RXZJ5wfrL2arX/PbZxqL3uk2BfEjA+6bXZr+rjiu9ZEp4NNIozEoyXuV55LATh2GWxIMe89eT32D82b8aXp7nkv3dBa0ih7MunXLa+iCHH97KfLoON5RKgHy2a44ZvwDA2IkWA3KRFph1qpqJ3oMjePDmHWvZ99vPqhjQ74rmFmyqHoHB6M/8autoI5LZ9aZMyOS9VRurs0VDL6+kIOgbwDGdK/dCFEFPL0GJEiv1xZbsDjawkiUM8xWHpf2rQBj98Pi3jOLfXuvV248aqH1pqxlCZ0EWAOg==
- Authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=suse.com;
- Cc: "julien@xxxxxxx" <julien@xxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Artem Mygaiev <Artem_Mygaiev@xxxxxxxx>, "roger.pau@xxxxxxxxxx" <roger.pau@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>
- Delivery-date: Wed, 29 Sep 2021 12:55:06 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 29.09.2021 13:56, Oleksandr Andrushchenko wrote:
>
> On 29.09.21 12:09, Jan Beulich wrote:
>> On 29.09.2021 11:03, Oleksandr Andrushchenko wrote:
>>> Sorry for top posting, but this is a general question on this
>>> patch/functionality.
>>>
>>> Do you see we need to gate all this with CONFIG_HAS_VPCI_GUEST_SUPPORT
>>> as this renders in somewhat dead code for x86 for now? I do think this still
>>> needs to be in the common code though.
>> I agree it wants to live in common code, but I'd still like the code to
>> not bloat x86 binaries. Hence yes, I think there want to be
>> "if ( !IS_ENABLED() )" early bailout paths or, whenever this isn't
>> possible without breaking the build, respective #ifdef-s.
>
> Then it needs to be defined as (xen/drivers/Kconfig):
>
> config HAS_VPCI_GUEST_SUPPORT
> # vPCI guest support is only enabled for Arm now
> def_bool y if ARM
> depends on HAS_VPCI
>
> Because it needs to be defined as "y" for Arm with vPCI support.
>
> Otherwise it breaks the PCI passthrough feature, e.g. it compiles,
>
> but the resulting binary behaves wrong.
>
> Do you see this as an acceptable solution?
Like all (or at least the majority) of other HAS_*, it ought to be
"select"-ed (by arm/Kconfig). Is there a reason this isn't possible?
(I don't mind the "depends on", as long as it's clear that it exists
solely to allow kconfig to warn about bogus "select"s.)
Jan
|
