[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] x86/traps: Fix typo in do_entry_CP()
- To: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Tue, 28 Sep 2021 22:00:14 +0100
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Bobby Eshleman <bobby.eshleman@xxxxxxxxx>
- Delivery-date: Tue, 28 Sep 2021 21:00:41 +0000
- Ironport-data: A9a23:Ut9dFqvVwdwHbCcKxQj/BCIOa+fnVLZZMUV32f8akzHdYApBsoF/q tZmKTyOPKyKNDPwc9slPI+xpkwHuJXdz9A3S1E5ry80HiIQ+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHpJZS5LwbZj29Y524jhWGthh PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ NpliJm6EzpwJL/wh/0bSxB7MSojH6hv5+qSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DFYUToHx/ixreCu4rW8vrSKTW/95Imjw3g6iiGN6DP JpFM2U1MXwsZTUTMQcQF6wcv9uFm1zCTzleiXmvgqgetj27IAtZj+G2bYu9lsaxbdpRtlaVo CTB5WuRKhsdPtaOjzee8nahg+bJtSz+UYMWUra/85ZCkFCVg2AeFhASfV+6uuWizF6zXcpFL E4Z8TZoqrI9nGSJZNTgWxyzoFafowURHdFXFoUHBBqlk/SOpVzDXy5dE2AHOIdOWNIKqSIC6 1qDxe6wHy5Tr6STUXu+1LzJjzabJn1ARYMdXhMsQQwA6tjlhYg8iBPTU9pueJKIYs3J9SLYm W7T83ln71kHpYtbj/zkoQCvbyeE/MChc+Ij2unAsotJBCtXY5S5L6ih9FTW9/pJKIvxorKp5 yNfw5n2AAzjF/iweM2xrAclQO3BCxWtamS0bbtT838JrG/FF5mLJ9w43d2GDB01WvvogBewC KMphStf5YVIIFyhZrJtboS6BqwClPa7T4S4Cq2LNYYRPfCdkTNrGgk1PiZ8OEi3zCARfVwXY 8/HIa5A815AYUiY8NZGb7hEiuJ6rszP7WjSWYr633yaPUm2PxaopUM+GALWNIgRtfrcyC2Mq oo3H5bamn13DbylCgGKoNF7ELz/BSVibXwAg5cMLbDrz8sPMDxJNsI9Npt7INE6w/QJyL2Yl px/M2cBoGfCabT8AV3iQhhehHnHB/6TdFo3Yn4hO0iGwX8mbdr95asTbcJvL7Im6PZi3bh/S PxcI5eMBfFGSzLm/TUBbMai8Nw+JUrz3Q/ebTC4ZDUffoJ7Q1Cb8NHTYQaypjIFCTC6tJVir uT4hB/bW5cKWy9rEN3SNKC011q0sHVEwLByUkLEL8N9YkLp9IQ2eSX9guVue5MHKAnZxyvc3 AGTWE9Kqe7Iqo4z0d/ImaHb8Nv5T7ogRhJXRjCJ46y3OC/W+nuY7bVBCOvYLyrAUG7U+bm5Y bkHxf/LL/Bazk1BtJBxEug3wPtmtcfvvbJT0i9tAG7PMwawErplL3SLgZtPu6lKyuMLsAe6Q BvSqNxTOLHPM8L5Cl8BYgEia73bh/0TnzDT69UzIVn7u3ArrObWDx0KMknekjFZIZt0LJghk LUot8Mh4gCijgYnb4SdhSdO+mXQdnENXs3LbH3B7FMHXubz9mx/XA==
- Ironport-hdrordr: A9a23:lCcKT6AqXf70akHlHemi55DYdb4zR+YMi2TC1yhKKCC9Ffbo8f xG/c5rsiMc5wxhO03I9eruBEDiewK5yXcW2/hyAV7KZmCP0wHEQL2KhbGSugEIcBefygcy78 ldmtBFebjNMWQ=
- Ironport-sdr: 3pGIScqYZWlgbvqDQXtR7T7VKGUC7awDT85X5Xoghm8WdobPJZYJd1aIOanEPcpgDLKdlA4gFl W72thHOZTLumNn0oBn7eMI2TIyA4b6aPkv1b65voIchKG1LTd9nsthm+xPrXZsvhb/9A6n74Ib 07OwBluWObkPZPvWQCwe+ead25cCgfMjtLV7qzoNCHRO8HchTFrcFq6EP581xfg4t7AsCHxLwK tB9m87TW30uGDAueEHGxtyWt3UebQtF3ceIJU7xJVMC78jdMBfFaiU9HGGWgg1zEKkHLa6nnLP nPVS87u8qoBW4OJav3ixZ2VW
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
The call to debugger_trap_entry() should pass the correct vector. The
break-for-gdbsx logic is in practice unreachable because PV guests can't
generate #CP, but it will interfere with anyone inserting custom debugging
into debugger_trap_entry().
Fixes: 5ad05b9c2490 ("x86/traps: Implement #CP handler and extend #PF for
shadow stacks")
Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
---
CC: Jan Beulich <JBeulich@xxxxxxxx>
CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
CC: Wei Liu <wl@xxxxxxx>
CC: Bobby Eshleman <bobby.eshleman@xxxxxxxxx>
---
xen/arch/x86/traps.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c
index c2e2603c394b..63676b0a68ff 100644
--- a/xen/arch/x86/traps.c
+++ b/xen/arch/x86/traps.c
@@ -2047,7 +2047,7 @@ void do_entry_CP(struct cpu_user_regs *regs)
const char *err = "??";
unsigned int ec = regs->error_code;
- if ( debugger_trap_entry(TRAP_debug, regs) )
+ if ( debugger_trap_entry(X86_EXC_CP, regs) )
return;
/* Decode ec if possible */
--
2.11.0
|
