[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 07/11] libxl: Allow removing PCI devices for all types of domains
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>, "roger.pau@xxxxxxxxxx" <roger.pau@xxxxxxxxxx>
- From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
- Date: Mon, 27 Sep 2021 07:17:25 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=PmU+17d68n/+dmGiPuNg9noukYa/3K2MoitkwNtDdVQ=; b=dTw+f0uNDwdljl7BXytdiNO1BDj+GCkJS9ReVhCrOpMW3S2dMjn2vEm1w3vVn+OJeis2NaNMNcbECZllhILjHew0LcI0TUTxMIvPa8L1bVq3eL4up0Vd3Yrf88BKwOn1RjRHNW1SukIDcUHllM8Dhmq0bKE9xgC864xNewmLcTExWCYNA9529zqg7LN4yrqitUpo50+zx6qCCaV86syqRZoKmCuP/AACXHtkkgjbjKniJ6Cih1LnVzYqMLY1w0nlWeb+g/Nwp4fttdeFgJ/XGjyC+F2cotMlT2t05ZuMgtJa0hYwaQJWHFCFuWO7nl9tJqvfYqzCA4USNWqc373Iug==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NAa8K3EHsKHN/X7bEYwkQWe3FDlbaExopjU2vAQ2fpdCmVAzkyh6l1ANMLAV4Cx6sj/YIFaAJ8SwHhJv4Y4X8L+p1ZasPF/TTjURsBPrmTFCQx3bsRk5RctGJ1ADz0tmWqvyTT2gwVfj0/e76nroMXNdyJ+FgGshDLVHg8QL2HpPlvPl3iDc9JYabSFqY0kHQQRjsd9bz3TA6Qn9ofKxYJFyAUU543S0ZugiQWGsQg0UCsfMdJXBeQUPciRFt+DcAh3jL2EzI4DKzkO9/LYmr0Bzzqt9s3wiSza//mjxWJHmi1NUeWcymAcQg4lViQmHWT+vfc+jVQFzuhnLHE6CrQ==
- Authentication-results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=epam.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>, Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Artem Mygaiev <Artem_Mygaiev@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>, Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, "jbeulich@xxxxxxxx" <jbeulich@xxxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>
- Delivery-date: Mon, 27 Sep 2021 07:17:33 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHXsHo0SAN7/ZEcjkCS11geMNuE5quz35wAgAOe3wA=
- Thread-topic: [PATCH v2 07/11] libxl: Allow removing PCI devices for all types of domains
On 25.09.21 03:00, Stefano Stabellini wrote:
> +x86 maintainers
>
> On Thu, 23 Sep 2021, Oleksandr Andrushchenko wrote:
>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
>>
>> The PCI device remove path may now be used by PVH on ARM, so the
>> assert is no longer valid.
>>
>> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
>> Cc: Ian Jackson <iwj@xxxxxxxxxxxxxx>
>> Cc: Juergen Gross <jgross@xxxxxxxx>
>>
>> ---
>> tools/libs/light/libxl_pci.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/tools/libs/light/libxl_pci.c b/tools/libs/light/libxl_pci.c
>> index 1a1c2630803b..59f3686fc85e 100644
>> --- a/tools/libs/light/libxl_pci.c
>> +++ b/tools/libs/light/libxl_pci.c
>> @@ -1947,8 +1947,6 @@ static void do_pci_remove(libxl__egc *egc,
>> pci_remove_state *prs)
>> goto out_fail;
>> }
>> } else {
>> - assert(type == LIBXL_DOMAIN_TYPE_PV);
> This is fine for ARM, but is it OK from an x86 point of view considering
> the PVH implications?
Long time ago I was asking Roger about that. At first glance the change
seemed to be ok, but Roger could you please confirm this?
Thank you in advance,
Oleksandr
>
>
>> char *sysfs_path = GCSPRINTF(SYSFS_PCI_DEV"/"PCI_BDF"/resource",
>> pci->domain,
>> pci->bus, pci->dev, pci->func);
>> FILE *f = fopen(sysfs_path, "r");
>> --
>> 2.25.1
>>
|
