[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 36/37] xen/arm: Provide Kconfig options for Arm to enable NUMA
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Wei Chen <Wei.Chen@xxxxxxx>
- Date: Fri, 24 Sep 2021 10:37:04 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=B0elbpzxYorW87yCM8WsQtWw5QXTwy1oDV/rL89rzRo=; b=CC+Kr1IZvrfCt4f01sd1yrALPz6IUtRtHKxTD80Pe+zwjCIPGxiFt6PnoXedDEedLw8ukPVAxgNNxyaMkZvowcBoaRlode2/ZhuxbdGPfTy0t7bh4dmNnmMlcAMcZgKBYtWhp8kXJAoQSSFAu9HdA7NCxMy3GLxG7F8GnSuM7pkq/Yvicavu0rqRKBvlxbAYBlP9/D8Ck6u31H4rHybtSAgklFnbTFlUv3kLjAcVR9/1IGMww8YxFqEBT9IGICRRq13jDJysMDIcsVWwLhGhKgBZDns94vfP8ThCiCErwaoGz1q8w7Ss0qZrvWJ93ONP42jK3erX6U4JqderYij9XA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E4Tc9A0JHxgKbbwUY5x36opJBfk65B0dNg6vTKMNcNgUYwOKK2G97wknBXw7b8Y9izsjJrb4quXZEuyCj5Utvq5v2rLKZx2HGoSapMWhXo82In7wAPx8/QoN2m51NCpBcZlKPxLPQ7f0y1dLEMriXL303ebwVMEc10wtIW5oDMd/lzlfj5bNkCTzwM/b8P/HNn70uOgvF5I9mJTlH5UW9JZ/4wbu6NXvajcTSc+9j/qbWOKcrDsKv6zaGwLdZvLmzJlD6OKMF4VUEf/bXXroMao4QvxWSvBm+hjfKIZ3nFCGj+y2bPiNdMD7uT4dOjznnB+6nCT1KBpnjwPOYPSoyg==
- Authentication-results-original: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
- Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>
- Delivery-date: Fri, 24 Sep 2021 10:37:28 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHXsHM4CZyvsR6BnEO/IHEJe48Inquy/CcAgAADDZA=
- Thread-topic: [PATCH 36/37] xen/arm: Provide Kconfig options for Arm to enable NUMA
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: 2021年9月24日 18:26
> To: Wei Chen <Wei.Chen@xxxxxxx>
> Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>; xen-
> devel@xxxxxxxxxxxxxxxxxxxx; sstabellini@xxxxxxxxxx; julien@xxxxxxx
> Subject: Re: [PATCH 36/37] xen/arm: Provide Kconfig options for Arm to
> enable NUMA
>
> On 23.09.2021 14:02, Wei Chen wrote:
> > --- a/xen/arch/arm/Kconfig
> > +++ b/xen/arch/arm/Kconfig
> > @@ -34,6 +34,17 @@ config ACPI
> > Advanced Configuration and Power Interface (ACPI) support for Xen
> is
> > an alternative to device tree on ARM64.
> >
> > + config DEVICE_TREE_NUMA
> > + def_bool n
> > + select NUMA
>
> Two nits here: There's a stray blank on the first line, and you
> appear to mean just "bool", not "def_bool n" (there's no point
> in having defaults for select-only options).
>
Ok
> > +config ARM_NUMA
> > + bool "Arm NUMA (Non-Uniform Memory Access) Support (UNSUPPORTED)" if
> UNSUPPORTED
> > + select DEVICE_TREE_NUMA if HAS_DEVICE_TREE
> > + ---help---
>
> And another nit here: We try to move away from "---help---", which
> is no longer supported by Linux'es newer kconfig. Please use just
> "help" in new code.
>
Thanks, I will do it.
> Jan
|
