[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen: fix broken tainted value in mark_page_free
- To: Penny Zheng <Penny.Zheng@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 22 Sep 2021 16:12:32 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Du2wDA6nvKLVsZijKk1h7XmI403NREUTTlM8111wuVI=; b=lOb32P4N4AKMARc4zc8boVtR+g/qmDgw4EPG7jbZpAcOSDl94r50JVwWvcDl5p4P1UhO6wT3ddfOIYmG9uUOHzJhjL4TyaeyRRTEp037t12Zwewn5h9M/Fkw2EyOSpn9Jylf7UwdL31lIvT5I2ppf/lUoYB9MOMqY2k2VwkgTxxhggjvEPCjsPGVg04LTFDnmi/ACuFbeakT7QQkVVrAG+3W3lnKqISC/Sg0WGoxVShttoeXUMZvWw3s4kSXqjq2hGEZ2h4Pj9YMHBsNXzK5Wk2vOwb4lmAzENFIOYz+RLnH4zS1nzgbb5JErubk4j8+hTgGv7uYilmSYBbCaFZOIg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TTCgNlgqO0DCuVx7OJJmBE3Jm9Lge1A+RwJC2niDE0AbyMOdQUfHQnXf9bpUPbBR0VW1H0EIL9co9BOGV0m9ikah2KRuq4tHuzrY+Dvm5G5hQar6VVJiDwJgkLAJVTyx2SUKEa2oH0YJsIS1LnHb/ueLaXelVmwHES8PBpYANDHlKl2IkuhUbaDNb/Xax0mmn4Yt1/47KDzyknFuIj7rDtr+/YCc4zBUYes4m3wN9+y2UNhxGlTEamVHOG4pJIbvZk+ErHB+g+Odzpp87/cyyieVQVT5J00rdyQmrL8OOyKPfmLgQpt8I4KEQkn0Jgeome9s2k9lE3h9m6GUqKK2lw==
- Authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=suse.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Delivery-date: Wed, 22 Sep 2021 14:12:47 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 22.09.2021 13:48, Bertrand Marquis wrote:
>> On 22 Sep 2021, at 12:44, Penny Zheng <penny.zheng@xxxxxxx> wrote:
>>
>> Commit 540a637c3410780b519fc055f432afe271f642f8 defines a new
>> helper mark_page_free to extract common codes, while it accidently
>> breaks the local variable "tainted".
>>
>> This patch fix it by letting mark_page_free() return bool of whether the
>> page is offlined and rename local variable "tainted" to "pg_offlined".
>>
>> Coverity ID: 1491872
>>
>> Fixes: 540a637c3410780b519fc055f432afe271f642f8
>> Signed-off-by: Penny Zheng <penny.zheng@xxxxxxx>
> Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
Albeit I would have wished that ...
>> @@ -1433,7 +1437,7 @@ static void free_heap_pages(
>> {
>> unsigned long mask;
>> mfn_t mfn = page_to_mfn(pg);
>> - unsigned int i, node = phys_to_nid(mfn_to_maddr(mfn)), tainted = 0;
>> + unsigned int i, node = phys_to_nid(mfn_to_maddr(mfn)), pg_offlined = 0;
... this would have become properly bool as well.
Jan
|
