Re: [PATCH V2 2/3] xen/arm: Add handling of extended regions for Dom0

[Julien Grall <julien@xxxxxxx>]

On 16/09/2021 00:10, Oleksandr wrote:
> > > + * The extended regions will be prevalidated by the memory hotplug path
> > > + * in Linux which requires for any added address range to be within 
> > > maximum
> > > + * possible addressable physical memory range for which the linear 
> > > mapping
> > > + * could be created.
> > > + * For 48-bit VA space size the maximum addressable range are:
> > > + * 0x40000000 - 0x80003fffffff
> > Please don't make Linux-specific comments in Xen code for interfaces
> > that are supposed to be OS-agnostic.
> You are right. I just wanted to describe where these magic numbers come 
> from.
> Someone might question why, for example, "0 ... max_gpaddr" can't be 
> used. I will move
> that Linux-specific comments to the commit message to keep some 
> justification of these numbers.
Please keep some rationale in the code. This is a lot easier to 
understand the code without having to play the git blame game.
Cheers,

--
Julien Grall