[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/6] xen/credit2: Remove tail padding from TRC_CSCHED2_* records


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Fri, 17 Sep 2021 14:28:58 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=NKQPTZs0jxTjQ9A1ySBjY71pxV11rHjXty003ceqxio=; b=cJvEVU7Sisbef9lFhXzObRXsLTmrmfYmZ+GSp5/wl9ZqWf+LgO7whD3roOydJiXpNNBGeru3AFYpzPfssBsem445s3MdeNecZTnKDBSnuo56zE4hb7XfDZAQoVPQh2yUBGvDLjZP0jfBsLgBhR4elc/ev/W+NxdaED8LoGtNuc47daYcUPCuSYFVScIYoPKBlE3tZQQevbRgaYu3GBvI7E20nfBknoUGbUW2J5GaTSPVrAxZiR8QhoXLWuZQFDe4BjGjncXBfz5ALfMd4i9dPGKmN4L9/fZ7jOfl1Xz/8mxMUSCdPkBurelOoCbQFyYm7Q5An5bkfwHFKM//8KgGsw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EvQvhb1d/qPMzoBzjMQ+9+lrSY6E+hAVf0ezOVBk9n+GUcxs3LCuCTltzEpRFT/oETiT4aFWUljej1E4TAYTz5SdxpVwhk0G7eaXiqmxbuBk/6HcneRYsI15Z6Gv7UWXuLf4C7uphit6W1mVd7zEBOPQQlMXDnjAPwSm8dI4BLU0+RyZUjeRciF81TU1rUMiRw4e3yEjyTnEbx3GeQZ8nBltKvzh2PXN/kMtcqdUfB4XZGM5JxzHPyRIC3zXgKrqILJ0MEqVW1AbaWA3JZDtFwPMJAiAeo9DLVsSBheRAFLelQX/SEbq/Hxd8LTSY6wMuIPNAGEJ5XvTokOTSJGhRw==
  • Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Dario Faggioli <dfaggioli@xxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Fri, 17 Sep 2021 13:29:19 +0000
  • Ironport-data: A9a23:RsRbiqwKMhoPTGhKZGp6t+e2wSrEfRIJ4+MujC+fZmUNrF6WrkVVm mEYCDvTMvaCZWb3KIokbISx/U8G65CEyIM1TlA6/yAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAsLeNYYH1500s7yrdm2tQAbeWRWGthh /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt9lXl O5thZrrcwEGJfPqldgWWUV9MD4raMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr 6ZBbmlQMFbT3Ipaw5riIgVoru0lINPmI8U0vXZ4wCuCJf0nXYrCU+PB4towMDIY25ofQq2FP ZJxhTxHSR3GYT9UZ3QsOZMQrMu5gCHNegZFtwfAzUYwyzeKl1EguFT3C/LOYcCDT8hRmkeep 0rF8n7/DxVcM8aQoRKE7XCEluLJhTn8Wo8ZCPu/7PECqF+Zy3EXCRYWfUCmuvT/gUm7M/pAL 2QE9yxoqrI9nGS7Q9+4UxCmrXqsuh8HR8EWA+A88BuKyKff/0CeHGdsZjJPYdMptcgyRBQxy 0SE2djuAFRHsqCRSH+b3qeZq3W1Iyd9EIMZTXZaF01fuYCl+dxtyEKUJjp+LEKrptTTRQrQ8 zbRli4RnOs1gPIA3fme3k+S1lpAuaP1oh4JChT/Bzz+t1MiNd/9PeRE+nCAsq0Rd9/xok2p+ SFewpnAtrhm4YSlyXTVKNjhCo1F8Bps3Nf0uldpA5Bp3DCk4XfLkWt4sWwmeRsB3irpf1bUj K7vVeF5v8Q70JiCN/Yfj2eN5yMCl/OIKDgdfqqIBueim7AoHON9wM2LWaJ39zu2+HXAbIllY cvLGSpSJS9CVMyLMwZat89CiOR2l0jSNEv4RIzhzgTP7FZtTCfOEt843K+1Rrlhtsus+VyNm /4Gbpfi40gPAYXWP3iMmaZOfA9iEJTOLc2vwyChXrXYeVQO9aBII6K5/I7NjKQ+w/0Ox7uXp yrkMqKaoXKm7UD6xcyxQikLQJvkXIplrGJ9OiopPF2y3GMkb5rp56AaH6bbt5F+nAC65fIrH fQDZeuaBfFDFmbO9zgHNMGvp41+bhW7wwmJOnP9MjQ4epdhQS3P+8PlIVSzpHVfUHLvuJtsu aCk2yPaXYEHG1ZoAvHJZa/91Fi2p3Ucxr5/BhOaPtlJdUzw24F2MCit3OQvKsQBJEyblDuX3 gqbGzkCouzJr9Nn+dXFn/nc/YyoD/F/DgxRGGyCteS6MizT/2yCx45cUbnXIWCBBT2soKj7P Ldb1fDxNvEDjW1miYskHuY517866vvuu6ReklZuEkLUYgn5EbhnOHSHg5VC7/Uf2r9DtAKqc UuT4d0Ga66RMcboHVNNdgooauOPiaMdljXItKlnJUz74Gl8/aadUFUUNB6J0XQPILxwOYIj4 OEgpM9JtFDv1kt0ao6L3nJO6mCBDn0cSKF25JgVDbjihhcv1lwfM4fXDTX74c3XZthBWqXwz uR4WEYWa2xg+3f/
  • Ironport-hdrordr: A9a23:lEaMYKsRijKSzOPv7NhMkjTq7skCJIAji2hC6mlwRA09TyXGra GTdaUguyMc1gx/ZJh5o6H+BEGBKUmskqKdkrNhQ4tKPTOW+FdASbsD0WKM+UyaJ8STzJ856U 4kSdkDNDSSNyk4sS+Z2njDLz9I+rDum8rE6Za8vhVQpENRGtxdBmxCe2Cm+zhNNXF77O0CZe OhD6R81l6dUEVSSv7+KmgOXuDFqdGOvonhewQ6Cxku7xTLpS+06ZbheiLonCs2Yndq+/MP4G LFmwv26uGIqPeg0CLR0GfV8tB/hMbh8N1eH8aB4/JlbwkEyzzYILiJaYfy+gzdk9vfsWrCV+ O8+yvICv4DrE85uFvF+icFlTOQigrGoEWSuGNwyUGT0fARAghKVvaoQeliA0TkA41KhqAh7E sD5RPri7NHSRzHhyjz/N7OSlVjkVe1u2MrlaoJg2VYSpZ2Us4fkWUzxjIZLH47JlO31GnnKp gZMOjMoPJNNV+KZXHQuWdihNSqQ3QoBx+DBkwPoNac3TRalG1wixJw/r1fol4QsJYmD5VU7e XNNapl0LlIU88NdKp4QOMMW9G+BGDBSQ/FdGiSPVPkHqcaPG+lke+43JwloOWxPJAYxpo7n5 rMFFteqG4pYkrrTdaD2ZVamyq9CllVnQ6dgf22wqIJzYEUaICbRBFreWpe2/dI+c9vcPEzc8 zDTK5+Erv/JWGrHY5I2mTFKtBvFUU=
  • Ironport-sdr: XsUgqEzkGOvXZ+bbzB/UuN6vkjGHb6NjvdKS1EHlwfoGekNVJEx/5SuxZhRQXnft+MhJ0z9scE 7nN5NJsVplM0jyDaI9ZUOiPPqmL0gPUG+euxrIowUdI1zPHd+gBed41fDarYUkgQ+x6SaSTTKQ wCpY9iYfHvRvpU8Tplocg8dsxgZQqMSqMDY+IsMunAAQ/jxRFYt9/MyQronndEl0JvlWeLdS1d ssIxZP0vw90FOsDj7LdM+BocS02t5eYhP1L5CmXjJTeB7qMMaa7Nzup8JZLPb9Zj7ht2A60oiL xgnMZECkasu+Sd8r94ZmfmWr
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 17/09/2021 14:10, Jan Beulich wrote:
> On 17.09.2021 10:45, Andrew Cooper wrote:
>> @@ -1336,13 +1338,16 @@ update_runq_load(const struct scheduler *ops,
>>      {
>>          struct {
>>              uint64_t rq_avgload, b_avgload;
>> -            unsigned rq_load:16, rq_id:8, shift:8;
>> -        } d;
>> -        d.rq_id = rqd->id;
>> -        d.rq_load = rqd->load;
>> -        d.rq_avgload = rqd->avgload;
>> -        d.b_avgload = rqd->b_avgload;
>> -        d.shift = P;
>> +            uint16_t rq_load; uint8_t rq_id, shift;
> Split into two lines? Preferably with this adjustment
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Thanks.

> I'd like to note that the remaining uses of "unsigned int" or plain
> "int" in some of the instances you don't touch assume
> sizeof(int) == 32, while generally we assume only sizeof(int) >= 32.
> This is one of the cases where fixed width types are imo mandatory
> to use.

See patch 5.  There was far too much cleanup to merge with this patch.

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.