[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH net][RESEND] xen-netback: correct success/error reporting for the SKB-with-fraglist case


  • To: "netdev@xxxxxxxxxxxxxxx" <netdev@xxxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Fri, 17 Sep 2021 08:27:10 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=HWKHW7ZoiNVaIy0mfo3LS1NtMKPljl8Txy7BqM8aytQ=; b=iFP8GZQRiNLvgYFHFfd/cZRlx8c/xh71RocLtmSEFJu2Abx7keyP9LNBpMsYGYff/5D1h35pA01hG8x7RnsBhpCEOhxxFQ68z0RTE4qJfJgCvCJ0HLFQH2UR0JnMmAObOC8q8+1dR0qSzW6ZD6IsxzreDn1OWuSIhxZ+LLvcVCb5B2pgKkWZxMMACkRNvvtoX2bgHV9n/rPPg7PvRtP16pu07bOv6xyq+brhLPgpZG/2HLsKs1MFyJ6/abf289bCZHTUWwBeOijnQ30I/rANzj+x8/fN5U449y2yRGjJyMTeLPP/p4fhnjeMthEK+d98gpfTmn8etW2orxZyrraV4Q==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q25i2ebGgB79+F5oGE336FliMymy9jndvpF6sCPFMpktHzv9fCJBD6V6/RDhbTOb/8v+/+UTwoWnDgX2PGmf6EWUU/Vewo44f+sVf0543zaZlqQ7Zy0Iv0S5r10aSgjfyShMbf6JidR3YQOMwF2IR3TVP8XebuZNgXLFMKxBGR5Fv9oHff0rrmu2THRs8k0sTQlbtzhclbn8CBQsEHkGKzLJjTYQQipsJwzYUJ1TMYT0hWkk9LDatGGg8M7tvQ5L0FzlBBjXfSUzWg87jy4fduWxsWH5bPXCfC3QFRHwCToW8MUCPm2X3d3BN3dxi01MwPnbC/0hEElEeQHtcUhxOw==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: Paul Durrant <paul@xxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Fri, 17 Sep 2021 06:27:22 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

When re-entering the main loop of xenvif_tx_check_gop() a 2nd time, the
special considerations for the head of the SKB no longer apply. Don't
mistakenly report ERROR to the frontend for the first entry in the list,
even if - from all I can tell - this shouldn't matter much as the overall
transmit will need to be considered failed anyway.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Paul Durrant <paul@xxxxxxx>

--- a/drivers/net/xen-netback/netback.c
+++ b/drivers/net/xen-netback/netback.c
@@ -499,7 +499,7 @@ check_frags:
                                 * the header's copy failed, and they are
                                 * sharing a slot, send an error
                                 */
-                               if (i == 0 && sharedslot)
+                               if (i == 0 && !first_shinfo && sharedslot)
                                        xenvif_idx_release(queue, pending_idx,
                                                           XEN_NETIF_RSP_ERROR);
                                else




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.