[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 08/14] xen:arm: Implement pci access functions
- To: Rahul Singh <rahul.singh@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
- Date: Wed, 15 Sep 2021 07:54:30 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ZCa6er99XD9a2CQzg8T0mQjKx6vdmU9JwbkP0jMKadQ=; b=mOKM+rcnRsMlXO8v44yJHo5WXzVxpO6dbzfwteNo9/ynD0QXHKGHzskxlr+1ceYfGjZgdRf6ucdph+79eiD67IwTGyPWj/Bkzh6N+7JyF0O6gLHmvjDAP1licUBcHKuMFLne+Q8T/GvpfnDbw+AjEWAMI6jMddGpbiGbkvEQBGosguvvI/No0uw4hU15fUVohuFi4U+K2BeTWtbzqSAWdVwOgeaGIDTjOkfZQaqpvj+uzHQLb8dkF49TYWrD9/N3MidOW4V/mUPnHKkExnHCMh5C3w0m2puLdwD++6u/ojeWmkdJkEwIKiftuaNBZ9zhumIT8iFuy9DtjGlOBGTOZA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XzbNATN7UDSdM9fRW5sHGqBg25Isk8q1RQymYyrRc+1rtXmytE4IKklXAwd+sW52sMvrOnPoux4rUOJN9DH6tkIMSd9d1NY8li2QqzS0xnpkuxMGMBDJxg/WL8594Ql3Lczd4v7OuVBz7berQ/1ZjiBTLBDlfoLyiYyYtQjAoNIIwFu/Zy5ZpE89DkmthrjWxnlhcBLoNrcet5G+w0qJFP0ZAnFtr27olEDMoey3jQ3CWDItl8N86Ru8VYKHVBth/bJwyOQJSb4FNYPdS5F8XhFCS+8KUTgyc+B0xvc7SBiQkxJs7rcaP6ffbypT3IsufnHU73lVlC1T/jeNJWvijw==
- Authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=epam.com;
- Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Wed, 15 Sep 2021 07:54:39 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHXqgbplAv3ejwcPEaBVpikglszUA==
- Thread-topic: [PATCH v1 08/14] xen:arm: Implement pci access functions
Hi, Rahul!
>>> static void pci_config_write(pci_sbdf_t sbdf, unsigned int reg,
>>> unsigned int len, uint32_t val)
>>> {
>>> + struct pci_host_bridge *bridge = pci_find_host_bridge(sbdf.seg,
>>> sbdf.bus);
>>> +
>>> + if ( unlikely(!bridge) )
>>> + {
>>> + printk(XENLOG_ERR "Unable to find bridge for "PRI_pci"\n",
>>> + sbdf.seg, sbdf.bus, sbdf.dev, sbdf.fn);
>> same here
> Yes I am printing with “PRI_pci".
vPCI and the rest are widely using
printk("%pp\n", &sbdf);
So, I think if we have SBDF then it is better to use %pp instead of trying to
unfold it manually.
|
