[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 09/11] xen/arm: Setup MMIO range trap handlers for hardware domain


  • To: Rahul Singh <rahul.singh@xxxxxxx>
  • From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
  • Date: Wed, 15 Sep 2021 05:30:40 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=+Js1ULUN0xbIjgVEqSHLxfhmwuL2sC6W2PAFSur+PnA=; b=bZyX9739LCjkvSgQfwDoXY0vNwe7+HZLL9JQn225rR+GYup7W6kjNQCyprwQYTiOCTFUnJucqcEn9XdDr2vDp/BL0RJd4OLWX/Cpw+TkI2JQ0cecBG3t2qbkhS38oDdfyV4q4QEDm+A3ayEenaGUpzJnddI9sy/bxIPSwBIxnYujnTEgh8da58Z/GngI9hWwXHyogGcOSleSIJkZyUcG7d0/r7gNt1z3dyJr1/Y5oDNczT1lH1bmx7RdP0Nh9+kn+wdl+sowc/nlxYxpzjkC5vv8UtACV0GPCJRmzsTeDiTQZNfWiVWtLomD7wNS031LDISlfuy8lUgm+BDe3275Ow==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VOH3gO/KC0caIx72XxhR+ZUu6I6/zZJ5pX34lC7MeKah4ZKP+ZgAho/pZ4RbfTwBBCAfSABtkXXUhqpTX7IpBG/Bo2iXw1CpHBJf3pB7ETJgttveWxPtNzFYxAZwn6dMIh6uJm85F3bwvTKRCob+pfR5GmBQZGFox2SKlquHiVl/MUS9SVDlfA4TZhctTz161m3bmCH/aOqmta9UYBJRY9AgXwmff++qzFyF9SKq3eiL81bjrg8lxhBzAmOtFmR/78g3Vew0D8TB/EZZk66YlvN+UA5pBoictPVpt42e/0evoIWy+D72ALrnh9fFOpYieZKogOFHkCYNb3Anom7xgg==
  • Authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=epam.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Artem Mygaiev <Artem_Mygaiev@xxxxxxxx>, "roger.pau@xxxxxxxxxx" <roger.pau@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Oleksandr Andrushchenko <andr2000@xxxxxxxxx>
  • Delivery-date: Wed, 15 Sep 2021 05:30:59 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHXoJ6eIuPEzuAZLUmx1GA90MGEBKudvyQAgAXn/ACAAP1GAA==
  • Thread-topic: [PATCH 09/11] xen/arm: Setup MMIO range trap handlers for hardware domain

Hi, Rahul!

On 14.09.21 17:24, Oleksandr Andrushchenko wrote:
>
> }
>>>   +static int pci_ecam_register_mmio_handler(struct domain *d,
>>> +                                          struct pci_host_bridge *bridge,
>>> +                                          const struct mmio_handler_ops 
>>> *ops)
>>> +{
>>> +    struct pci_config_window *cfg = bridge->sysdata;
>>> +
>>> +    register_mmio_handler(d, ops, cfg->phys_addr, cfg->size, NULL);
>>> +    return 0;
>>> +}
>> Given that struct pci_config_window is generic (it is not specific to
>> one bridge), I wonder if we even need the .register_mmio_handler
>> callback here.
>>
>> In fact, pci_host_bridge->sysdata doesn't even need to be a void*, it
>> could be a struct pci_config_window*, right?
>
> Rahul, this actually may change your series.
>
> Do you think we can do that?
>
This is the only change requested that left unanswered by now.

Will it be possible that you change the API accordingly, so I can

implement as Stefano suggests?

Thanks,

Oleksandr

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.