[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 05/10] xsm: apply coding style
- To: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 10 Sep 2021 08:15:09 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=oa6kPufnjAtEzVpGtQRxfkESNGWmP/ZewBL4bZsgzo8=; b=DSZDP5LHsnNwx9IR6r4R+mRTDThajz9d9q44YFc2JWlZ+6napwrBAKRI5hxQBX9z1GoVkTUElm+KcvWfRfBPwI8VBUp/oYeQ2GWGXb6+C85UwTSLCup5zpIngt6dcOPjVjZGyHlRwp7G9o4fqJ/lqYP19rY7T2uNi91S+XvLam45LjGvc8qnIPcigq5JWedpv+U1HW32b07knSbZJN2esFMalifBFYEheKEqeJdCDt+FmcrawmsYQVFOw1cJzkZAHepmf3FaV5BFO4HU4pLwTRkAvuchl/jKLs8bzOssRb5GGZD7+W/wywIlkGVwaARqAsbKWnVGvyoL55WibgqkxA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P/XWkjstGGo7eXhH5EthMNse6B8Am9T8n4jSNytI/5Eoh2r9jxEYK7mVcq2rxx27nEL5TY31z9jprxHmZspMR/Hy1W5AV2rOGQDJ/EduxaQa4qRQfyRH1Ld87ZWf3SKUqi952zE1j7EtIa2Yrddf47DHMyPhLu0DLCTwkw5kX1hXeIVBttCzYQC3cTqXPB+44PVwFwCFyhvuNrdEVqnEeJisRboQJqx4YD55Tu/ZdHXkO6gdGx3aevZYx1csvvMr2L9gfHGqsiJzMTYGg7N6Y9yL88gerEe2p9AGEfeWjRVeH1XYM+VdVMb7GJfgeeiP8EZO+82BjHv42ZqG3DVZXQ==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 10 Sep 2021 06:15:17 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 10.09.2021 04:12, Daniel P. Smith wrote:
> @@ -70,7 +73,7 @@ void __xsm_action_mismatch_detected(void);
> #endif /* CONFIG_XSM */
>
> static always_inline int xsm_default_action(
> - xsm_default_t action, struct domain *src, struct domain *target)
> + xsm_default_t action, struct domain *src, struct domain *target)
Here and below you're now introducing hard tabs. In Xen style
we don't ever use hard tabs for indentation; this is limited to
files inherited from elsewhere.
It's also not clear why you've touched this instance at all:
The 4 chars indentation was correct already, as previously
pointed out by Andrew (on perhaps a different example).
Jan
|
