[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/balloon: use a kernel thread instead a workqueue
- To: Juergen Gross <jgross@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
- From: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
- Date: Wed, 8 Sep 2021 12:05:24 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=WOotRj4nQjDKasrtz0snA9uu+YSNII+Jq0+VtpkJHbw=; b=ct5aYIbohUwIxYkHIesKQPTqfXxKM5LjHSNn8TWV/ggHXUEBNwa8KxEtyoKGm8wdGYdh6Y0cMiQ8jWESLAVY0mbem9nITqmo1hfY43LJjePn+C8xRDBS7YYuPlADH9cPDBHmHPbaP5EC0nST0oy5HLykPKizGcP1gYlBDzRn9mPt8yNgjsIwj9xajxU8kmRoICMvrV4MltyVz3PYcW/RdnGPt//+Ce8yt5GxAKAwMsieA/mDLWHU45siezvx1KhYSxIiZqHBPdkgkekocyahH2BqpRg4n+A2LUaJtC1xGEzLbEjUnw643+PFRSzbWyVh1ebhkURKfRvZlalY9CuJMQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eBtMP37QRI4HPrJ/rhg3UCgFtzCCQIaS2fn3vf7IMyokCjw74oYxHhOTxIIulA83HADjFj7GkmZ4M0tC7NXZR9iuwL5c4+JZGCvCFCj1PGaRuETgkLjFKdj5QiiRwGsYlhH5n0DPtCAKUqbxCuudV9ODuwV6biOLsD5ZDYKCyq76NgZ4moB+iOco/khDjxFcVLrDCQ0ETy73t/OW2ry2YVwVevmC4MZ/rhWn0PiA4Mf8wIk7vkh+nm2vn0gAvGZ853E/vZ8WJTaKumNXUzISPGGYugOYxPUjnq+0T1s64GP7Unac2ZE+01qWOVHujv6XDRuq1nVno9CuGoOJG8JABw==
- Authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=oracle.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
- Delivery-date: Wed, 08 Sep 2021 16:05:47 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 9/8/21 11:11 AM, Juergen Gross wrote:
> On 08.09.21 16:47, Boris Ostrovsky wrote:
>>
>>
>> Given that wait_event_interruptible_timeout() is a bunch of nested macros do
>> we need to worry here about overly aggressive compiler optimizing out
>> 'credit = current_credit()'?
>
> I don't think so. current_credit() is reading from balloon_stats, which
> is a global variable. So the compiler shouldn't assume the contents
> won't change.
Ah, ok --- good point. Then I guess we should be fine.
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
>
> But I can add a barrier() after 'credit = current_credit()' in case
> you'd feel uneasy without it.
>
>
> Juergen
|
