[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 9/9] xen/x86: adjust data placement


  • To: Juergen Gross <jgross@xxxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 7 Sep 2021 12:13:07 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=uHbz7vDnLyWZn+Vx+UcHtoqyEcsa9/5Gh3CvlM0cqI4=; b=SV1lgHXViEVBZwaxVWq5uFMF/sQPvP/wYSZD0ULY57z+Y/56InsHTil2/lY9qNm6K86QhRH9xPTfYdOL0l61THIgqSgt1OI2bods2dHS3917F/K3IG0PJZo49riBhXU6y0Pfi66Hu0ozpLtWJYRaQjWqib8uI2OUIyhz1ipxhA5woFhokQb2P6ZLdHsqOC5/hXvsqtt0gijogZNeqcdzoHQmK3QJd1PGi0H7oNQokQDLjjY+BxkWNfe9/qU7oA0XzkfOSDZKavbrMZfqUO0k11b9xnvJ72b1q4lJyqNuxzCKUoFuVhMpApnBY0XG3Lhm4ePisABDVehASkMDl+fvQg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CO9BcPUPSzL297plkLrfWFu7JBxYVt7I/sm2DxAIRgrmZVbvi88U8qguy6371yqm9kz8qhMwxhMFFLRlhZ5HY82bQayRNOVCOBIm24CVkrvKHw4FftUdWiMOmcgRDpXOHqTYgFxfUNaYU/yIdNnVvBOCkOwEu83JoWaGYeC3Lta0648dZZsaC9Jsu4+BzQRNV2aMnemE7SNIwIxb2Ocnevp/nvLQy2KaClYIll4E7TCpQVczB7ewPfwjulesVAp66T6xc4Qr73ObL8p1dRSa7pqfu0KJVsiwHi7oL0LWJ6hLCaTisVnRvsFdv8JzX5lYTEgGhpxOAFAH579+F0qz2A==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, lkml <linux-kernel@xxxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Tue, 07 Sep 2021 10:13:15 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Both xen_pvh and xen_start_flags get written just once aeryl during
init. Using the respective annotation then allows the open-coded placing
in .data to go away.

Additionally the former, like the latter, wants exporting, or else
xen_pvh_domain() can't be used from modules.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
---
I have to admit that it is completely unclear to me which form of
exporting I should have used: xen_domain_type is GPL-only while
xen_start_flags is not, yet both are used in similar ways, extending to
xen_pvh.

--- a/arch/x86/xen/enlighten.c
+++ b/arch/x86/xen/enlighten.c
@@ -75,7 +75,7 @@ EXPORT_SYMBOL_GPL(xen_have_vector_callba
  */
 enum xen_domain_type __ro_after_init xen_domain_type = XEN_NATIVE;
 EXPORT_SYMBOL_GPL(xen_domain_type);
-uint32_t xen_start_flags __section(".data") = 0;
+uint32_t __ro_after_init xen_start_flags;
 EXPORT_SYMBOL(xen_start_flags);
 
 /*
--- a/arch/x86/xen/enlighten_pvh.c
+++ b/arch/x86/xen/enlighten_pvh.c
@@ -1,5 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
 #include <linux/acpi.h>
+#include <linux/export.h>
 
 #include <xen/hvc-console.h>
 
@@ -18,10 +19,11 @@
 /*
  * PVH variables.
  *
- * The variable xen_pvh needs to live in the data segment since it is used
+ * The variable xen_pvh needs to live in a data segment since it is used
  * after startup_{32|64} is invoked, which will clear the .bss segment.
  */
-bool xen_pvh __section(".data") = 0;
+bool __ro_after_init xen_pvh;
+EXPORT_SYMBOL(xen_pvh);
 
 void __init xen_pvh_init(struct boot_params *boot_params)
 {




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.