[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [XEN RFC PATCH 39/40] xen/x86: move numa_setup to common to support NUMA switch in command line


  • To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • From: Wei Chen <Wei.Chen@xxxxxxx>
  • Date: Tue, 31 Aug 2021 13:44:00 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KAb7vEZQADkHgIoesvFIBFZlYv5WAe5H1iBu4IqQCYA=; b=nKdQmrS1Tnz4JdKskZcjzFMLGlQtLoCyHNpkfwHgnOnnU849G8y//JvpktqNxlbOg8h5WUjRm9sEjDc5m696rliM+hvD55z0iVuJGICQb2JoVmQLUIUfc76bTBSegs0YIpQKJSDvyoUECAXdRumIWNugfOts6cDzxzti2gJt1zNWHuwakzKu3dfxSuNcPGBrxAjt0Y5Nxr5/s/HownjyrJlLmmNH4WWUq5hQhwrvIsUbFb5P9v8RQwyLl9Jwhve8exoc+CJfQFq+3h4RKcGmd7fmJyHgph52mzlZISbTCCUYzn7J8CpxN+uptdb8jMOZC1L5OOu4CUWK00t/XERAqg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fByrg1QmjyrREVx5DIbgLyyua3NDWthQF+6y8CDnBDWE6YhNOHH2GhjtNLsVvYQttr8zhqFLCBznHoCw5GFht64A59PXaf/vxDgLSNybEPjenaLgjvNlbPIQSqChSj9txEamaQMQUgdZiggnfhyWtGTfmJa1Ela4Sfmqq3Gh8Nti6ZJ4lqX4wr2TOgMCW0z5qFzD+qcrmuCEEB11xsWLv5fbKbhCpjmlhMfuD5Xh4Etosy/uthM0tx0e1G7m5q279LAvgkEy6H0Y9FNj8Fl5H5N+zlqXZU698jIUGhMjZvOjq4C3KGidG19LBg+ZioX0hBTJusDqngsRDfuv1JB0Sw==
  • Authentication-results-original: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
  • Delivery-date: Tue, 31 Aug 2021 13:44:15 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHXjptVFJvPelB8mUqFa8hfwTS7pauM+LqAgADCsPA=
  • Thread-topic: [XEN RFC PATCH 39/40] xen/x86: move numa_setup to common to support NUMA switch in command line

Hi Stefano,

> -----Original Message-----
> From: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> Sent: 2021年8月31日 9:53
> To: Wei Chen <Wei.Chen@xxxxxxx>
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx; sstabellini@xxxxxxxxxx; julien@xxxxxxx;
> jbeulich@xxxxxxxx; Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
> Subject: Re: [XEN RFC PATCH 39/40] xen/x86: move numa_setup to common to
> support NUMA switch in command line
> 
> On Wed, 11 Aug 2021, Wei Chen wrote:
> > Xen x86 has created a command line parameter "numa" as NUMA switch for
> > user to turn on/off NUMA. As device tree based NUMA has been enabled
> > for Arm, this parameter can be reused by Arm. So in this patch, we move
> > this parameter to common.
> >
> > Signed-off-by: Wei Chen <wei.chen@xxxxxxx>
> > ---
> >  xen/arch/x86/numa.c    | 34 ----------------------------------
> >  xen/common/numa.c      | 35 ++++++++++++++++++++++++++++++++++-
> >  xen/include/xen/numa.h |  1 -
> >  3 files changed, 34 insertions(+), 36 deletions(-)
> >
> > diff --git a/xen/arch/x86/numa.c b/xen/arch/x86/numa.c
> > index 8b43be4aa7..380d8ed6fd 100644
> > --- a/xen/arch/x86/numa.c
> > +++ b/xen/arch/x86/numa.c
> > @@ -11,7 +11,6 @@
> >  #include <xen/nodemask.h>
> >  #include <xen/numa.h>
> >  #include <xen/keyhandler.h>
> > -#include <xen/param.h>
> >  #include <xen/time.h>
> >  #include <xen/smp.h>
> >  #include <xen/pfn.h>
> > @@ -19,9 +18,6 @@
> >  #include <xen/sched.h>
> >  #include <xen/softirq.h>
> >
> > -static int numa_setup(const char *s);
> > -custom_param("numa", numa_setup);
> > -
> >  #ifndef Dprintk
> >  #define Dprintk(x...)
> >  #endif
> > @@ -50,35 +46,6 @@ void numa_set_node(int cpu, nodeid_t node)
> >      cpu_to_node[cpu] = node;
> >  }
> >
> > -/* [numa=off] */
> > -static __init int numa_setup(const char *opt)
> > -{
> > -    if ( !strncmp(opt,"off",3) )
> > -        numa_off = true;
> > -    else if ( !strncmp(opt,"on",2) )
> > -        numa_off = false;
> > -#ifdef CONFIG_NUMA_EMU
> > -    else if ( !strncmp(opt, "fake=", 5) )
> > -    {
> > -        numa_off = false;
> > -        numa_fake = simple_strtoul(opt+5,NULL,0);
> > -        if ( numa_fake >= MAX_NUMNODES )
> > -            numa_fake = MAX_NUMNODES;
> > -    }
> > -#endif
> > -#ifdef CONFIG_ACPI_NUMA
> > -    else if ( !strncmp(opt,"noacpi",6) )
> > -    {
> > -        numa_off = false;
> > -        acpi_numa = -1;
> > -    }
> > -#endif
> > -    else
> > -        return -EINVAL;
> > -
> > -    return 0;
> > -}
> > -
> >  /*
> >   * Setup early cpu_to_node.
> >   *
> > @@ -287,4 +254,3 @@ static __init int register_numa_trigger(void)
> >      return 0;
> >  }
> >  __initcall(register_numa_trigger);
> > -
> 
> spurious change

got it.

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.