[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [XEN RFC PATCH 34/40] xen: move numa_scan_nodes from x86 to common
- To: Julien Grall <julien@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>
- From: Wei Chen <Wei.Chen@xxxxxxx>
- Date: Sat, 28 Aug 2021 02:12:00 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZYaJYZhVT+uK0WbVMA8in17R1HTG2AimbO8+pYHkxBg=; b=IWB0u8D6DDyGeKU1DLWlqUWALzfmEgbAsr3UJS1o0TI5xKeufw5T8S+2m7uGjHRoyZKGT6p05mGlA61VyM/yGZ33rXmu2+FCVZmWcivI2vab5zcWQtK5xT0gq3dKr5OnBeHNskOhUth6I8UF3U8vWUU981DYgpw4IWhqGdDOd4gbCT6jXSFIxP7WQ5mTBtRSsJrQVTM6F6Mkrul9v6oOuUVAkal82NfA7rCc1WUOSrHEPPG4Vt1w8Knrm6lRlK8bNOzTNzKR1rKXVWno90rScPURTAxY1TCGhmsCLEmzQNRYGvz2LsXhngflbYvYIlCUOIU/ZqNWu+zQgqQ09wuF3Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=COvEjyyHjGpCyybrYz0AyqfHCEyVpbsHe9XBalBtXBkDr13a8Gtu1Jc78AKQw0XoB/KAvzh2junVnwU2NqIGIKXUFtpUH8FovIFEI60FhHKGnXlQUKlB2EdKk+MPWv/hm3jt8/4qLrskVBEJDkuppUeNo2NGdLb550aviB8RpDpRl1iBUgDDLV2vo/c9LZ22IUIk46IV+E04M1D4+aD5S6NGaUyp6cRifFQEvMiFWXWm1zTHdm30+b+huRwK5sDgSXSdRWOS/1nq2hxCjVHF/FXVqsLrPLuKdwrU+653YGWVI6EyqKaRe35bSMqKXO6i0bYSVdHb0mWSQnK3ZzbPCA==
- Authentication-results-original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
- Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Delivery-date: Sat, 28 Aug 2021 02:12:21 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHXjptUu77aQcXH00SSr7Sat0uCZquHfl+AgADIgbA=
- Thread-topic: [XEN RFC PATCH 34/40] xen: move numa_scan_nodes from x86 to common
Hi Julien,
> -----Original Message-----
> From: Julien Grall <julien@xxxxxxx>
> Sent: 2021年8月27日 22:14
> To: Wei Chen <Wei.Chen@xxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx;
> sstabellini@xxxxxxxxxx; jbeulich@xxxxxxxx
> Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
> Subject: Re: [XEN RFC PATCH 34/40] xen: move numa_scan_nodes from x86 to
> common
>
> Hi Wei,
>
> On 11/08/2021 11:24, Wei Chen wrote:
> > diff --git a/xen/include/asm-x86/acpi.h b/xen/include/asm-x86/acpi.h
> > index 33b71dfb3b..2140461ff3 100644
> > --- a/xen/include/asm-x86/acpi.h
> > +++ b/xen/include/asm-x86/acpi.h
> > @@ -101,9 +101,6 @@ extern unsigned long acpi_wakeup_address;
> >
> > #define ARCH_HAS_POWER_INIT 1
> >
> > -extern s8 acpi_numa;
> > -extern int numa_scan_nodes(u64 start, u64 end);
> > -
> > extern struct acpi_sleep_info acpi_sinfo;
> > #define acpi_video_flags bootsym(video_flags)
> > struct xenpf_enter_acpi_sleep;
> > diff --git a/xen/include/xen/numa.h b/xen/include/xen/numa.h
> > index 490381bd13..b9b5d1ad88 100644
> > --- a/xen/include/xen/numa.h
> > +++ b/xen/include/xen/numa.h
> > @@ -81,8 +81,10 @@ extern void bad_srat(void);
> > extern void numa_init_array(void);
> > extern void numa_initmem_init(unsigned long start_pfn, unsigned long
> end_pfn);
> > extern void numa_set_node(int cpu, nodeid_t node);
> > +extern int numa_scan_nodes(u64 start, u64 end);
>
> AFAICT, by the end of the series, the function is only called by the
> common code. So this should be static.
>
OK
> Cheers,
>
> --
> Julien Grall
|
