[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 8/8] AMD/IOMMU: respect AtsDisabled device flag
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 26 Aug 2021 16:33:29 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FKomc0gOOeog6f4TbOaHv8w1grUrr7hsGPuPJt0oTz8=; b=fEU2kXZw5dTsmid8a4M4kONb8oSEDfKIjW5r6enghSKnoNYVVesIWLmuRmBKp+ryeWd8D8D4yRG3t89JZW6UE+Bq8hQA08h1Sh2E0WauzEwmEZiosNfc7nscZQtredxHTtgLArSVbuzD6axYPRYK4Gu5Gh8f4aB/8hJCCZz9uJI8dyYVzKsPhacpPBGw6DVUrxgD58JxIaz/GHAzyWV2I7lObdi82X0BZpmi8WpS1WdU3CogsEl69Zgjnu++8uMaQms14WKePpiVyuUVBhdmIzl3WzZcxB+iZOrZIDl4CeYw927cxK0g3wEqS8tevHys1aLlyCSl3CLGSARw6IC3iA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A8tJBMNaKkAV0lwlrpT8GaStOMJagWHhDKprmmyw1WendinXY+mDiJDrS6QkC3WPhrdfbKVj12Nmz/oEvAvJoayKhImLm65BnbvLTcu3aIoJlYqMJGRdqS3H0D5E4akqNN2IE74nuXFVgxp/xvc3jkGsTJlfgO1jeVLdssORw/LNveourml6L6giitWhZrcVD5e1ek3bbshMxOeAhupetStCdgxgsOuRtAnpCL9iWh/E01aWbKnt1mBBlKapgrBbJgN2M1cRj6uGKoFhg5aY4a+LD8QLzNHp7GcxBhefWA1SN7Ga542GPFnSuAuLPV0bS8JIN9hlYB7ilUKtsZQyNQ==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: Paul Durrant <paul@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 26 Aug 2021 14:33:40 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 26.08.2021 16:27, Andrew Cooper wrote:
> On 26/08/2021 08:26, Jan Beulich wrote:
>> TBD: I find the ordering in amd_iommu_disable_domain_device()
>> suspicious: amd_iommu_enable_domain_device() sets up the DTE first
>> and then enables ATS on the device. It would seem to me that
>> disabling would better be done the other way around (disable ATS on
>> device, then adjust DTE).
>
> I'd hope that the worst which goes wrong, given the problematic order,
> is a master abort.
>
> But yes - ATS wants disabling on the device first, before the DTE is
> updated.
Okay, I'll add another patch.
Jan
|