[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 4/9] gnttab: drop GNTMAP_can_fail


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Thu, 26 Aug 2021 14:13:14 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ObSRKMfCjstOfp3bszIM3eFOroR3P+6H7iY2fC1WXf8=; b=bskz/6SMmMwjNopTmXj3cxp1SQ98jjOEVUFbn3ah7Y2Vc0veIS6ntbldJ+vCcsVDRpTcsovT6xnFcniDXm7F5JlpUAqAW0ZSMsGHG51mC7tXkgVLNZfrzhwxL5YPnfR0rB5oEjteE6vw/PPmOn8kWhHBW/ufLLMf2lSK86/fQpi1hkkmiPDBMrEHTS6dYUcvGFR5ubKoYkBVjZO5pGH7419koEeoetXL7yH368Qc/1CKg9cN3Ppf9GS9PYQcECTzFl1cIb1x6+Pu8ZD2EVLNttmiEHmmooZ4whWy/hUNYN67zr4vGD12F8ShtF9IHQe+2Z1b7VI5r0J7U/RRwv7/bA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MN/9ZoBgnseLMP9Pu6pyfDF8etF93S0CHnd3PHkKXJlwt09whmGP93q8oTgOZWskpZ0Aw4bmHDN9xL7mQe++dIc0wOWCFyg4gSzZxyqsIQJW1pV5ijXEuEzpXXNZ8YbxpFIIrbnRONLhQmJffgVXejX6Z0a8mzIqVnJPZFElO/KcD3+pQjq4R7+hDmHEJRTHLl4zrsIw/DL0nFv35Qr/tD9JwT9P26uQio1a8n+mO39OFc8dwdd23BiLvqDM0IIvHvrHosVuCP07n0CH+Ew/Nx/0CWb1bVncIS7SruVoPjWEtOrPrqiAkoo+/gip6WBpI/SGfNjDy/vmFTxvD//Q1Q==
  • Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Thu, 26 Aug 2021 13:16:46 +0000
  • Ironport-hdrordr: A9a23:3snsXq086mLdD24j7TVbagqjBTJyeYIsimQD101hICG9Lfb3qy n+ppsmPEHP5Ar5OEtBpTiBUJPwJU80hqQFn7X5Wo3SIzUO2VHYUL2KiLGC/9SOIVyEygcw79 YHT0E6MqyMMbEYt7eI3ODbKadZ/DDvysnB7o2yvhQdL3AeV0gj1XYfNu/yKDwHeOAsP+tBKH Pz3Lsjm9PtQwVsUiztbUN1LtQr6ue72q7OUFojPVoK+QOOhTSn5PrTFAWZ5A4XV3dqza05+W bIvgTl7uH72svLiiP05iv21dB7idHhwtxMCIiljdUUECzljkKNaJ56U7OPkTgpqKWE6Uoskv PLvxA8Vv4Dqk/5TyWQm1/AygPg2DEh5zvLzkKZu2LqpYjDSDczG6N69M9kWyqcz3BlkMB30a pN0W7cnYFQFwn8kCP04MWNfw12l2KvyEBS1NI7vjh6a88zebVRpYsQ8Ad+C5EbBh/374ghDa 1HENzc3vBLalmXBkqp/FWH+ObcGUjbIy32BHTr4qeuomFrdTFCvgglLfUk7zM9HMlXcegd2w ysWZ4Y5o2nTactHOhA7ak6MJCK4sGke2OEDIuoGyWRKEgwAQOHl3fG2sRA2AiUQu1/8HITou WMbLoKjx98R6rRYff+lKGjtCq9GlmAYQ==
  • Ironport-sdr: kFLfSmBfCNKrUVkDykcvYA0j9Kzqw/9l0gBs/sTO/qc5i+yWogsJ+ITHcsSd3nZX9uIdqh9lxy SALUNre2BjCHkX3DAuHm0T8wsy5G99qYqHPgTbvQnqK8YNYN1Xy/m+qrAULienoulU8+YSkHWy pkR4vHdE3NwkRnLvjvD0CHm5ITmrk4qEBQABM9/Wo9xrbgXQj5NMryg/XgSl9tMraKxhSxG+nN tAwArlYH9XusIoJe2zOJ1ZTDQ0RLAK5OlHbDYcUUMU31oUH2kV/UTO4m6rKDosIG8jsyz3kjMP HhG6yvi9s8LosfH+7DuMyOSk
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 26/08/2021 14:03, Jan Beulich wrote:
> On 26.08.2021 13:45, Andrew Cooper wrote:
>> On 26/08/2021 11:13, Jan Beulich wrote:
>>> There's neither documentation of what this flag is supposed to mean, nor
>>> any implementation. With this, don't even bother enclosing the #define-s
>>> in a __XEN_INTERFACE_VERSION__ conditional, but drop them altogether.
>>>
>>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>> It was introduced in 4d45702cf0398 along with GNTST_eagain, and the
>> commit message hints that it is for xen-paging
>>
>> Furthermore, the first use of GNTST_eagain was in ecb35ecb79e0 for
>> trying to map/copy a paged-out frame.
>>
>> Therefore I think it is reasonable to conclude that there was a planned
>> interaction between GNTMAP_can_fail and paging, which presumably would
>> have been "don't pull this in from disk if it is paged out".
> I suppose that's (far fetched?) guesswork.

Not really - the phrase "far fetched" loosely translates as implausible
or unlikely, and I wouldn't characterise the suggestion as implausible.

It is guesswork, and the most plausible guess I can think of.  It is
clear that GNTMAP_can_fail is related to paging somehow, which means
there is some interaction with the gref not being mappable right now.

>
>> I think it is fine to drop, as no implementation has ever existed in
>> Xen, but it would be helpful to have the history summarised in the
>> commit message.
> I've extended it to
>
> "There's neither documentation of what this flag is supposed to mean, nor
>  any implementation. Commit 4d45702cf0398 ("paging: Updates to public
>  grant table header file") suggests there might have been plans to use it
>  for interaction with mem-paging, but no such functionality has ever
>  materialized. With this, don't even bother enclosing the #define-s in a
>  __XEN_INTERFACE_VERSION__ conditional, but drop them altogether."

LGTM.  Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

>
> Jan
>





 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.