[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [XEN RFC PATCH 29/40] xen/arm: implement Arm arch helpers Arm to get memory map info


  • To: Julien Grall <julien@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>
  • From: Wei Chen <Wei.Chen@xxxxxxx>
  • Date: Thu, 26 Aug 2021 07:27:41 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S0kvqqBAWJXA86SltcJBpWS2wb9ML6I9tsKYUSNkeQw=; b=nS5djuBX9CR/IxYoHI/rX3+7Oz0/zKHLxFYd3ipFjQ9MlxngOCN6Ny8BT6JXzSWEnc8BDrUr9fdewSNu3B660qdYrrftdj68sxXDHWGlhIC0JZdYHgL5m1XAyxu8+sFPLEPogMgE8mPr9w30ft101EopFXHlnIrh7sOwodaoAfgg2k7cRhxkQqDeMyfLrjVgSSxSLQAJtTJ1ws/ylr/cpujrVpN8QpV+lqHp6ViJT2yArZTVj3gv4pzseGnVK0VUPZXg2HC0bBgZ8k0KsYchZu/rXlUiuXty1y9H3PBucS9lPXNSN5Fvlzkw4wK2H0cYHYk3/ZE5pTwrgmCZ7+0UBQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LgkYLRdNErl44Sn7ZVXyPaN0+6eu2pUVHIytch4hn7FSHbomILFicCDK2CD4aZM6rZjbxuRmar6kt9F4ZCuiPQjIkIMyviQkt9x7NiM5qwDPqrDwCPDmqpe0ixHpo1dJ0oOImn2o2Avnzu2X7jvp/FZ404Ef+bNSMRM00I8eKOQ5IpVZbuDiUUGz/goQYgXr2UlE1YhgY1dYV3W7xvinoL4J122Kzpof+vs1OPHMcZVRlhPfwEpgVR+Ho7hJpSZPeN/iyFRZD2NrNhwG1kO3Gkiuj+MBfEDT/2upaxQTPequD3PWV+Ccbs2gWqCEOheHw/9LyeFxHHCJEIh2MN6xcw==
  • Authentication-results-original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
  • Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
  • Delivery-date: Thu, 26 Aug 2021 07:28:01 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHXjptHOflEs7xJrkCP3afsREFdpquEitqAgADvaqA=
  • Thread-topic: [XEN RFC PATCH 29/40] xen/arm: implement Arm arch helpers Arm to get memory map info

Hi Julien,

> -----Original Message-----
> From: Julien Grall <julien@xxxxxxx>
> Sent: 2021年8月26日 1:10
> To: Wei Chen <Wei.Chen@xxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx;
> sstabellini@xxxxxxxxxx; jbeulich@xxxxxxxx
> Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
> Subject: Re: [XEN RFC PATCH 29/40] xen/arm: implement Arm arch helpers Arm
> to get memory map info
> 
> Hi Wei,
> 
> On 11/08/2021 11:24, Wei Chen wrote:
> > These two helpers are architecture APIs that are required by
> > nodes_cover_memory.
> >
> > Signed-off-by: Wei Chen <wei.chen@xxxxxxx>
> > ---
> >   xen/arch/arm/numa.c | 14 ++++++++++++++
> >   1 file changed, 14 insertions(+)
> >
> > diff --git a/xen/arch/arm/numa.c b/xen/arch/arm/numa.c
> > index f61a8df645..6eebf8e8bc 100644
> > --- a/xen/arch/arm/numa.c
> > +++ b/xen/arch/arm/numa.c
> > @@ -126,3 +126,17 @@ void __init numa_init(bool acpi_off)
> >       numa_initmem_init(PFN_UP(ram_start), PFN_DOWN(ram_end));
> >       return;
> >   }
> > +
> > +uint32_t __init arch_meminfo_get_nr_bank(void)
> > +{
> > +   return bootinfo.mem.nr_banks;
> > +}
> > +
> > +int __init arch_meminfo_get_ram_bank_range(int bank,
> > +   unsigned long long *start, unsigned long long *end)
> 
> They are physical address, so we should use "paddr_t" as on system such
> as 32-bit Arm, "unsigned long" is not enough to cover all the physical
> address.
> 
> As you change the type, I would also suggest to change the bank from an
> int to an unsigned int.
> 

I will fix them in next version.

> > +{
> > +   *start = bootinfo.mem.bank[bank].start;
> > +   *end = bootinfo.mem.bank[bank].start + bootinfo.mem.bank[bank].size;
> > +
> > +   return 0;
> > +}
> >
> 
> Cheers,
> 
> --
> Julien Grall

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.