[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 5/6] arch/x86: move domain_pause_for_debugger() to domain.h
- To: Bobby Eshleman <bobby.eshleman@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 24 Aug 2021 14:26:39 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1MfqT2WJO30CfmTzwUqbmbnLr8PHIZ8WLomKVonAbYI=; b=kSreOHqsGr0eQMz4FhfXSmNPo79Hap3qNjRei/ucbAQW5CKV6nbl4+TyAMqZcpkSF+OC/tD17rgeWYvtYQcjTb/MnIx/YmdFpzxEc9/+SvwYtVY17/dfXnaAdr1DkMcS+ZCYi6ExmLAXwUIGvPFi8tdfg0oE5YKK6I7QAqyqLDexSwFD+WFwVPwg98DE6fOjA3QDmKr3y/wGl/xWoNF36NR++UIb0TXLM3A2v5WkeV5iAXt88kCjPbkYj9XTJHlFzXzR3uoRA7uCi/JImrUr87J3vUIHoCO9wfLWeEpQyCQp31qKyz8VnSr0+fWLpAtSrmtMRRObrKWHd21oIwmgog==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iz/lpFxgggHOy6vSKB1KOKD0lDy73rpDE+h3a2jSFf18K/s70BRQkuss6JijIhzyjPnPW/N72Eh5WRYVrRzIx0PWuvUoTuskL2a0xPYbqgDqO7ljQ8EjD2H5WzRJSFkYrRVL5Z9J8SnFIn45U3uU3C6GuheLOfMF0c8ubKof7VwulPvRVTBYq52/pIawRJ9dChKjB8An9Uj/o8frk4bvLhDQcP/B3b0Dgzl2nqT1q/sXSRK2helsdDC5r6pTzvO5yNP4QJJJYofSrJTahNfN2m5dygMN8q1gBHvjy/NIS6R42u0BxEwF7j6tpc11dMFBEwOmK/sw//Gc+hZNj2kYbw==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Elena Ufimtseva <elena.ufimtseva@xxxxxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 24 Aug 2021 12:26:50 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 18.08.2021 22:29, Bobby Eshleman wrote:
> --- a/xen/arch/x86/hvm/svm/svm.c
> +++ b/xen/arch/x86/hvm/svm/svm.c
> @@ -36,6 +36,7 @@
> #include <asm/processor.h>
> #include <asm/amd.h>
> #include <asm/debugreg.h>
> +#include <asm/domain.h>
> #include <asm/msr.h>
> #include <asm/i387.h>
> #include <asm/iocap.h>
> @@ -58,7 +59,6 @@
> #include <asm/hvm/trace.h>
> #include <asm/hap.h>
> #include <asm/apic.h>
> -#include <asm/debugger.h>
> #include <asm/hvm/monitor.h>
> #include <asm/monitor.h>
> #include <asm/xstate.h>
While it's generally a good idea to explicitly #include headers that a
source file depends upon, I'm not convinced in this case: sched.h
includes xen/domain.h, which in turn includes asm/domain.h. And this
dependency chain is very unlikely to go away, as sched.h needs to see
full struct domain and struct vcpu, all of which come from */domain.h.
Jan
|
