[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/6] x86/debugger: separate Xen and guest debugging debugger_trap_* functions
- To: Bobby Eshleman <bobby.eshleman@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 24 Aug 2021 14:16:13 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/NXTAapnVYTNHAKIRL90F3KbzlRs/OJiVaVGYxo+StY=; b=fNnyF6ojL/Y0iWKDeDZgjrsEUlUCQMltOJCUPDTUmW0D5xEg/ReZ17MO9Pz7NEHAK+woY1L3T491hwA7FockXwE9NNpiZkiZcsMXAwJNWDWY2tXRkMAh8E3+RcSAk6CedVyA7DOcnXlt99X4LS+n2U+J0Cz4JJt6l8b79e80HGbYjrj2PL92rh1Py6ZG9oWXpMrFCOKvM15r1No4Ltq5wSO0M3pGQdQyYXgYakZUdIVmAk0d9iz8haGoKtCI6i6funU648gckpIrZ6GqB8yA/kKW8alqYq/i5yDlktuZFRuAJFDa8v1g/HgqmdIC3RaiS53UJYlG2UVUH2PpwBoZQw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i4NUZdHrOWlY5CUSi3XHhYpyvzSOzBVJzSkmGxgQKVYCXbZQwfZa1btKJ2AuMLLiTP94JnqbmuQFfsLFaYz3UyNmd3vnebGU0WXIU7oX3WuUd4fcObbu6WXGgBsmmoBecaQ06tpBiak2erRYH/Oly+VRQZD/51vkC2ooFKO8aJEtp8PSpXxzRNdyRfBji4GmVzFp2FDxEf0P5Kn0CaKfazfR17dhopDtZ9Vwt7I6BJFVAz8ddcwSLmnzudclb6+SqbqG8cU4HqB347IVtz8HiKp7Qq9wdOtsrdkosro1Bg69YkhkkE9k1iIL98LrgZevb2gHaDELjQ81lLjwjFOFvg==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Elena Ufimtseva <elena.ufimtseva@xxxxxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 24 Aug 2021 12:16:27 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 18.08.2021 22:29, Bobby Eshleman wrote:
> Unlike debugger_trap_fatal() and debugger_trap_immediate(),
> debugger_trap_entry() is specific to guest debugging and *NOT* the
> debugging of Xen itself. That is, it is part of gdbsx functionality and
> not the Xen gdstub. This is evidenced by debugger_trap_fatal()'s usage
> of domain_pause_for_debugger(). Because of this, debugger_trap_entry()
> does not belong alongside the generic Xen debugger functionality.
I'm not convinced this is what the original intentions were. Instead I
think this was meant to be a generic hook function which initially
only cared to deal with the gdbsx needs.
Jan
|
