[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 5/7] xen/arm: Use sanitize values for p2m
- To: Julien Grall <julien@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Mon, 23 Aug 2021 12:39:10 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3R9UmUQuParRVRHO+yeuPmtDYNAnIFC/HgVg53kldPY=; b=H7pz+T4bETjBlDsgEjHP3wri12UPz0j1VFfj3HYSCo8N/eBcKXju88u430M81ZUBQ5bYGhZ40onJ2sNBtMG6GXfJw+hKS3YeAM1+mIeiZFgdBMLqAmHkmUYzLqeYrkIv6J7itRj5CwWPZA7TU4Dw0oDBIM1dYad+8ul26FIPlXOhc7+uY4TRX3csDciJflR+3b6hNEGdmDXx+C9jOrJ/roFBCfnqVLCuAirD604v9sXTP1UPMi8tqfQh4rbePGprO9vAE+jX5kjzOmVJnHNbjmqh0wCFEHgBPqtzoMM/ausnaPwxHPXHGgrmkcUmO14yPhGd7Mzgy4say7sUwE+m5g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oI/21IBA77n60mKms3QTwmkuoj+4W2WydGpzfGyGiSE4uzDnHSLH8GGSK7xHlNj7/l49Kj+tCxCyarWojGm++KKo4JRufPYIddv6HU85AQD4xJkEzUorO/eEKNPOBsSfv0SEqPmpSxNezBmKF1SHF9IEZbsiewz6SXo5xC1RBkS2yJKIWUM1gLkC53y8DNZoNQKsotTS3v8UmV/scCycD+7jpjtf2wMyB+5bjINLHwsLCQyFrlV0kSSVDnSHeLqV4lLPXcwUFKQjiH8B4mDuB+hHxiUhJn65KfyNhrQgQcdZiYB/Md5bkO+gjmOBDUG8ZEiuoAsjrZrCqOA+lhKS5Q==
- Authentication-results-original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Mon, 23 Aug 2021 12:39:32 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHXmApoMVB9cWExpU2kmUfkwXVwUKuA+VSAgAAOUYA=
- Thread-topic: [PATCH v2 5/7] xen/arm: Use sanitize values for p2m
Hi Julien,
> On 23 Aug 2021, at 12:47, Julien Grall <julien@xxxxxxx> wrote:
>
> Hi Bertrand,
>
> On 23/08/2021 11:32, Bertrand Marquis wrote:
>> Replace the code in p2m trying to find a sane value for the VMID size
>> supported and the PAR to use. We are now using the boot cpuinfo as the
>> values there are sanitized during boot and the value for those
>> parameters is now the safest possible value on the system.
>> On arm32, the system will panic if there are different types of core so
>> those checks were not needed anyway.
>
> So the assumption is that if you have the same MIDR, then you must have the
> same features. I understand this is what Xen assumes today but I never viewed
> that check as the truth. It is more to limit the damage on most platform.
This was the assumption before, I did not change anything but just explained in
the commit message why this was not possible to come to this code.
>
> So can you confirm whether this is something that Arm guarantees?
For a specific MIDR from Arm (ie a Cortex) the PAR is fixed and VMID size to.
But for an other Arm architecture processor I cannot say.
>
> That said, I am not against removing the code. But I would like the comment
> to be amended if this is not a correct assumption.
Would the following be acceptable:
On arm32, Xen is not booting on systems having different MIDR amongst cores and
it is assumed that cores with the same MIDR will have the same PAR and VMID
size.
Cheers
Bertrand
>
> Cheers,
>
> --
> Julien Grall
|
