[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] AMD/IOMMU: don't leave page table mapped when unmapping ...
- To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 19 Aug 2021 10:03:41 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xCCpoNqhblmLpk0P7zYov9YQAq2XJomF6+kzvqV+EAA=; b=HqVilDbFu1zKbSHQ3LqzsTsy9tu3csndVTtp6Clf2t5oJK6IlYQzU16XwdAKBlEJdEEvmQrWwICK6p8kBaMYQj+CfL6WmYVekuq1MvsONElk4IXpi+HoGvthJ7xbyb7uqKmCyI9V2MrwKYhrCZOFwTkSuYnX+dvIWaYog9W+q8fiNDsKztJxMYeNjczHw2d+NdYrVD/PEM+Qo+UUxls25YxZPTdzMQtutEVgBgzyuhW48LnmYzWBO3tV5jANEy7qyiOv6ZSMJ3tfJgEWNYfGjwi3cRi7Dg8vXte9NbxdfIzDcpwhfvxwYeMgtEHDotOkzI/MyzPJkCKR1tGbwXzfJQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TrpKyplUGLwW4IGb+qCgpP12qf3oSDpQC9t3QpU1RcifQUzxVlxeqDxUne1w2DM2aZlB2uBxK6WFj5ay07sqVVkVqe0bBYlHyvPm3NXzjZQJ+TE+o0d07s0Ybw09xpSfXy+F2A3K2YriEGrhvCLma5DlgvmZOHY7/1E4oeAVfbPQGuYz1crIYGADv7jaoGNPLAoehf6KQROMtIp2ueGm4wnrlhTJcXMIHnQtWxfbcrepkGdOYWs9ZuXn63RvogyXrQliSSv0xZFPbgFRafg6dkS3krvH2gvJQi/Lef41VGdkB4adKp5Oi4NNknACTQDKp6ZJqgA4KQBgcEbSDwqDOQ==
- Authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>
- Delivery-date: Thu, 19 Aug 2021 08:03:58 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
... an already not mapped page. With all other exit paths doing the
unmap, I have no idea how I managed to miss that aspect at the time.
Fixes: ad591454f069 ("AMD/IOMMU: don't needlessly trigger errors/crashes when
unmapping a page")
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
--- a/xen/drivers/passthrough/amd/iommu_map.c 2021-07-22 08:07:12.501229386
+0200
+++ b/xen/drivers/passthrough/amd/iommu_map.c 2021-07-22 08:08:02.360893418
+0200
@@ -243,7 +243,10 @@ static int iommu_pde_from_dfn(struct dom
else if ( !pde->pr )
{
if ( !map )
+ {
+ unmap_domain_page(next_table_vaddr);
return 0;
+ }
if ( next_table_mfn == 0 )
{
|
