[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v2] x86/PV: suppress unnecessary Dom0 construction output


  • To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 17 Aug 2021 16:27:28 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=40US14X/1jgZPiEiNTxfN9+abFvahdUTbEzEluiRlXk=; b=JSUaAKbNerqv7kC8XSTBL+qtWwrpWnAshvvrOXtfe/Q6no8UfVMy60+bFwvaZ9bt8A7Xblo73GI0h1wcupcKDHIqojG5WBHopXDMkJUkTcwo69enypodW+2FrWUNUvZS0SkIdnK4SI9V1jlI/Rf7l3o0JVvD1KfeA+nlOpwh6mAyaUT5wweelMN/VAEr0xVIbSRGuAr9KKUlv1LSruuStpAWrpoYYTqB8nJap8PjjEU6M9Y6Pd71xEHCKntNZ6k7RLWe2TotZSHcGfoJ8E45ECjMCn8XlzCryCNDgHNNZG9KLU90yhhugGIdx+TIea+xOC9Ev/o8uz1pgBMkzKywfg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WLMOBSXzYQsitooBlyD6B9UvQxpYVVWeuE+7IW+MTnOzurTlrROBAwcD02gGU/Iqyx9A8Y4X6D2p6ondAIJyw3HJHVh8tyJIawRoy5MVgS8tfafqBM7DTy6j7S9yksgeWMi+k8LuA7jFxh9YyXKC3FXJgBVWIQ98axWfEcEvZtYi2L1rDcJbdpEjBdpZH41mVKTw4k9YCh0AP1ou6Y5iYWuNOfZ42DZA3SKOjldYnfYgloM3QXkHqUPBpNanuE9gplaZ4UmtxSJvRPhKp9uY+o9cqikV9666xyqi/wCFMF6yTlBvtsAoTv2KGrza3XlDlmlrltCDH6PwkjP84LLwEA==
  • Authentication-results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Tue, 17 Aug 2021 14:27:39 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

v{xenstore,console}_{start,end} can only ever be zero in PV shim
configurations. Similarly reporting just zeros for an unmapped (or
absent) initrd is not useful. Particularly in case video is the only
output configured, space is scarce: Split the printk() and omit lines
carrying no information at all.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
---
v2: Split printk() and replace / extend #ifdef by if().

--- a/xen/arch/x86/pv/dom0_build.c
+++ b/xen/arch/x86/pv/dom0_build.c
@@ -575,25 +575,21 @@ int __init dom0_construct_pv(struct doma
         printk("\n Init. ramdisk: %"PRIpaddr"->%"PRIpaddr,
                mpt_alloc, mpt_alloc + initrd_len);
     }
-    printk("\nVIRTUAL MEMORY ARRANGEMENT:\n"
-           " Loaded kernel: %p->%p\n"
-           " Init. ramdisk: %p->%p\n"
-           " Phys-Mach map: %p->%p\n"
-           " Start info:    %p->%p\n"
-           " Xenstore ring: %p->%p\n"
-           " Console ring:  %p->%p\n"
-           " Page tables:   %p->%p\n"
-           " Boot stack:    %p->%p\n"
-           " TOTAL:         %p->%p\n",
-           _p(vkern_start), _p(vkern_end),
-           _p(vinitrd_start), _p(vinitrd_end),
-           _p(vphysmap_start), _p(vphysmap_end),
-           _p(vstartinfo_start), _p(vstartinfo_end),
-           _p(vxenstore_start), _p(vxenstore_end),
-           _p(vconsole_start), _p(vconsole_end),
-           _p(vpt_start), _p(vpt_end),
-           _p(vstack_start), _p(vstack_end),
-           _p(v_start), _p(v_end));
+
+    printk("\nVIRTUAL MEMORY ARRANGEMENT:\n");
+    printk(" Loaded kernel: %p->%p\n", _p(vkern_start), _p(vkern_end));
+    if ( vinitrd_end > vinitrd_start )
+        printk(" Init. ramdisk: %p->%p\n", _p(vinitrd_start), _p(vinitrd_end));
+    printk(" Phys-Mach map: %p->%p\n", _p(vphysmap_start), _p(vphysmap_end));
+    printk(" Start info:    %p->%p\n", _p(vstartinfo_start), 
_p(vstartinfo_end));
+    if ( pv_shim )
+    {
+        printk(" Xenstore ring: %p->%p\n", _p(vxenstore_start), 
_p(vxenstore_end));
+        printk(" Console ring:  %p->%p\n", _p(vconsole_start), 
_p(vconsole_end));
+    }
+    printk(" Page tables:   %p->%p\n", _p(vpt_start), _p(vpt_end));
+    printk(" Boot stack:    %p->%p\n", _p(vstack_start), _p(vstack_end));
+    printk(" TOTAL:         %p->%p\n", _p(v_start), _p(v_end));
     printk(" ENTRY ADDRESS: %p\n", _p(parms.virt_entry));
 
     process_pending_softirqs();




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.