[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: S3 resume issue in xstate_init


  • To: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Tue, 17 Aug 2021 14:57:51 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wtn5WP+KjTNUlImYOvr3sspHcuBLG0Gp9FTlPLQGhwc=; b=dIYew2uVRR69MmXO9ccTxAdOjdcY1bPO162LkjzJ4VaTgqVSm6FKYckBoBf0vQ2tsGD6a943UBXValjZqI3nepzKNPTtBmQ8gMdw9/cpes3YnPdSEn2ePHRdbLv0MyWcOqOKgVqTwyrYrjUA6ythQzexBIzsJDMRIlE90Zmt0rsPdqAVDQfgGEqIs61V1miPQ73KdqSJxV0Rror0xsOoC8dqZhrSC0C6RUEnRUkg2YD7PAQ6dVQsFcLE8HFPJJrGYrzn2EcoZ9KK2ZauhfHpMMQDpStjBvmW9RPDWpz+gA1rnpBTyhBJNhegH/VtTzFrWqzdf9kFDefSyqvTK/vNzQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cekLOSgiDaCOhmqR2z2+CNHK2oA1FEYIb7hO+mKV8+q+jT/P8sL3/CiEdMigL87nl1UdExaa4GN/M/jqKT5gBqdfrcjE4es5+GVVZuiLKO0d5z+ys7qNK7Efa2bx0nFqh/iUEb0Ys9kd0D20OWaa/4okKz4ajdLXzpJzn4jVohHl8/c9mt5TpTZtjCrUvacI8ezNM90HwgZF8za0c+UISCU0gOFYlbL3LA4KDC3+ZK6TD1GPxG2Hcd2KNADe2QQHsLEOitRZ1IPoEujMohNtw1IQVui1cWQCCHShqL8FqmH5WX8sGxABUdIkgG9e7ebY6d8G4QK0gt/PITNlvy4X7A==
  • Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Jan Beulich <jbeulich@xxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Tue, 17 Aug 2021 13:59:08 +0000
  • Ironport-hdrordr: A9a23:ofl3gqgONcV9xSn0V59bARSLHHBQXiwji2hC6mlwRA09TyX5ra 2TdTogtSMc6QxhPk3I/OrrBEDuexzhHPJOj7X5eI3SPjUO21HYS72Kj7GSoAEIcheWnoJgPO VbAs1D4bXLZmSS5vyKhDVQfexA/DGGmprY+ts3zR1WPH9Xg3cL1XYJNu6ZeHcGNDWvHfACZe OhDlIsnUvcRZwQBP7LfkUtbqz4iPDgsonpWhICDw5P0njzsdv5gISKaCRxx30lIkly/Ys=
  • Ironport-sdr: QjLeqKqgAxZWPVy54x3+HU+JVwmQE4wQxrbHoi3u0XXL2Vfo7xMEI/lt6zuuGX5k15LGLUBZkI iN/gJQxsG0azbpMxi/0mtt6sw1NVLAzDZ09YWiAvrxLm74eJgeU+usM6Z4LQ4+ICxj+ztYWgtz myovgGP6oTxQyup2aRQfeKGe0QdZ5n5reYK8k0+RqpNUJLljZFvBwJCoU7eIxCqJhbCKngmowP i1dqxTqJUHxsNJqLpCAJbN9BZ4mYHO2/s0GG5ot2Nqq2rC3NOlkw+kaVL2AQO/pxxWzkU8M/Ei YLfR0c9qBQpZ0hb/tlNdqJ/J
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 17/08/2021 14:48, Marek Marczykowski-Górecki wrote:
> I've added similar cache init for XSS - and this one should be safe-ish
> - get_msr_xss() is not used anywhere.

XSS, and compressed xsave state handing in general, is in a dire state. 
What exists in the tree currently is a lot of dead code.

I started working to fix it, as it is a hard prerequisite to supporting
CET for guests, but as usual has been pre-empted by more important things.

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.