[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/PV: suppress unnecessary Dom0 construction output
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Mon, 16 Aug 2021 17:20:56 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JIy/G0yIBdOD7DjFG5VmrJ+6lI/ivmSzVqrhV3lRyXU=; b=gqoAeDXqNoNMGojP/vb+NpK30cTdT5XYJHX9Zw+j8tbp/w1sEe9sbF0O5+ZzC5v1bY94GItPwnoQFKYsDJjhdBdgH4TXVF7w0yppQS4KOpplyd1DKQdDsyiLFNUsRAxmTHwp+mZ3RlZIgHxwwKmKYLXin20OBADzb9IcsBnAnGNzpkTLiQ1Nl++BvrkoECHK/p5ujdzfeZuB1bxzL72CwUym2rlPt216rryrPHiAcRmMvE62E39LCQOjVqPN0B2PRA6Rnt6mvvhTeDEB8t1gq7vnNEw2gcE7tVz32iC1GTUIJqoSB1uDXSwwsSNKmutHS6IgWY6j2fW+SGWyRf586w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eoQdC7qgIH8Yeignzavo3B5hCcH5U7pjNXvy4Q1wK+/rhG8YkS2jKxsFLeXXCLlnMKJi1JHLJ0CxDDbhpMDixpmiTTzNoVEcfKCuoOfU807vXgXzhUXXbK9Ah0qany9gOu6QOpdGAlXUPtznsmX2UtRSq5ZhagYrS4epRD6nS4Gudz0AMFwxUeArbQKLlvZeu0OxLP+Q+3mhgyBkic/X6L2Qjd56tQ7NXcyCcMVJTb2+XgjGeIUxaZ8atvZD6RQfL5kYH6rZou+O8tPWvjKGxHg2AHphzyyTr+97gZ9ZOgiF8n1H0fPTixvVD/tNBskighpqdlkdGQUMSdOA05EauQ==
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Mon, 16 Aug 2021 16:21:15 +0000
- Ironport-hdrordr: A9a23:yhJnmK4pR+yuKCVdhwPXwUaBI+orL9Y04lQ7vn2ZFiY7TiXIra yTdaoguCMc6AxxZJkh8erwXZVoMkmsiqKdhrNhQYtKPTOWxVdASbsN0WKM+UyZJ8STzJ876U 4kSdkFNDSSNykLsS+Z2njALz9I+rDum8rJ9ISuvUuFDzsaD52Ihz0JezpzeXcGIjWua6BJdq Z0qvA33AZJLh8sH7qG7zQ+Lqf+juyOsKijTQ8NBhYh5gXLpTS06ITiGxzd+hsFSTtAzZor7G CAymXCl+SemsD+7iWZ+37Y7pxQltek4txfBPaUgsxQDjn3kA6naKloRrXHljEop+OE7kosjb D30lkdFvU2z0mUUnC+oBPr1QWl+DEy60X6wVvdunfnqdyRfkNxN+NxwaZiNjfJ4Uspu99xlI hR2XiCipZRBRTc2Azg+tnhTXhR5wiJiEtntdRWo21UUIMYZrMUh5cY5llpHJAJGz+/wJw7Ed NpENrX6J9tABCnhkjizy1SKeGXLzMO9k/seDlFhiXV6UkXoJlB9Tpc+CRF9U1wra7UIvJ/lp f52qcBrsAEciZZV9MkOA+tKfHHfFAleii8RF56F26XXJ3vC0i93qIf349Fk91CWKZ4gafay6 6xHG+xiwYJCgvT4Iu1rcZ2ziw=
- Ironport-sdr: eSSlIEV8pAooJlgsFb6Jy+Cu3VX+unJIzbl+M1YncoLTAEkwUftA5RM0IoO5Adbp89An7YLSGh oIQsvZPji9tvY1T2L9WXerWHcpwU37M0DA7TdIknerdYaCGOHtXDF3ipDpKhzWaLwAeYRFD8A2 kQNNrnEhUH7A8YBcQZRVL7urrV2IW5i3CrA3cjvXe04YOwyZySqhS32Cc4X5JQAfRFzdG3DNsV QCoEhPa8T5dFTdQX2fXrLFbM+iOoi8PDbc5tZPmABDpeGApa8mjyMqPVFNJOz02+mKYzkH8f50 d0YgClYAjnkfAgbLGJHpZA3T
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 16/08/2021 16:30, Jan Beulich wrote:
> Especially with XEN_GUEST, being a prereq of PV_SHIM, defaulting to N,
> v{xenstore,console}_{start,end} can only ever be zero in such default
> configurations. And in case video is the only output configured, space
> is scarce. Omit the two lines carrying no information at all in this
> case.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> as this is an
improvement, but honestly I think it would be better done differently.
Each line ought be a separate printk() in the first place, and these two
messages should be conditional on opt_pv_shim rather than
CONFIG_PV_SHIM. That will also shrink the output for native boot when
SHIM is enabled.
It also lets you conditionally drop the ramdisk line which has some
conditional printing a few lines earlier for the physical layout, but
unconditional printing for the virtual layout.
And on that note, the earlier few printk()'s really need some newline
corrections.
If you do go with this approach, feel free to retain my Ack.
~Andrew
|
