[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/ACPI: Insert missing newlines into FACS error messages


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 16 Aug 2021 15:58:38 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cawSzcYJfROd2jb4EE2GMwzerhen/U4FzMbtEMqPZnY=; b=BBj39jka9Rzh0Jjflj/oNhUPa7jhl3brJE76NA+IrAg+cw/Xb2UCtFFbDnfL2W39aeLMP5ga3Wc6vpuQ2tM5yHgFTinEhJ2eXfSstBsj/DYC3s+XigfKKDX05rlNgv8IfEIFbm1bvBR2emnrtDqI6gKHrQ3vBaF7l/qgjeJRtJdkL9CGG6/FGm5glZpBezeGKG+9M/LYbkdZRHZ5E9JdoJP9jDYLd4aI6O79ohTZM0VGQ1fEl4f73EiGtQ9lBD5hP5Fnwp8T4slbwWSNOs5kUSdGChmgX4W1k2O8GDtWuQB0OzT2S1aFYMTGQgGgTfio13Hg4jdZAf7AN1DEy/4vIQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C7KKW8IcaQKxA5sRcRg2LBFzGy3M1ExlZHF0X9i5QP4Z9R7KyEOpBrWfar8ywTzd/3xNUE4c/P5QSzJfzY2KpvnSgg1zlNXVsF5uVmI1SEe2ZxqwaPEEhvhbgrMDCRidbeOBHJXsvPZm1DacVSyFgC0u6OFO+qv90DEkYpMFmHz3aFGLvgTGf7at2UcxmgRKFv3q0Jp03Q/VNLOAy68KAQLsbVY/bCvLmSEkPAEViwXjuKe+w7QWt2SS96JRCRK3JNa8Us+3B6N3fGWT+3lNARB0rPCB04YCe1hqdx+GWCvU+avY7A87ZvjmYFupOc+MkUWMheTrWVmaANgDNEJ5KA==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Mon, 16 Aug 2021 13:59:02 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 16.08.2021 15:35, Andrew Cooper wrote:
> Booting Xen as a PVH guest currently yields:
> 
>   (XEN) ACPI: SLEEP INFO: pm1x_cnt[1:b004,1:0], pm1x_evt[1:b000,1:0]
>   (XEN) ACPI: FACS is not 64-byte aligned: 0xfc001010<2>ACPI: 
> wakeup_vec[fc00101c], vec_size[20]
>   (XEN) ACPI: Local APIC address 0xfee00000
> 
> Insert newlines as appropriate.
> 
> Fixes: d3faf9badf52 ("[host s3] Retrieve necessary sleep information from 
> plain-text ACPI tables (FADT/FACS), and keep one hypercall remained for sleep 
> notification.")
> Fixes: 0f089bbf43ec ("x86/ACPI: fix S3 wakeup vector mapping")
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

I'm curious though how you came to notice: I hope there isn't any
hardware/firmware actually triggering emission of these log messages?

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.