[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xen/lib: Fix strcmp() and strncmp()


  • To: Jane Malalane <jane.malalane@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Fri, 30 Jul 2021 11:12:18 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YE6/4WW4sIiXbBb5N2uvrbE4CjYGV5flH4D5d8/c3KE=; b=AG6A8BhgAM5nJ2FZAPiB+bAJMjuU27qi25UR1x0S1lzDctxX6Icw2OAzXDCMNVLLERVKSCVnWJFoEXt9PNmLY41oMZiNpioEsunObMqo3Gp2hzPF0Xy2YV9udnoQxgBkfuLcIBHr0Ciw+2kGMXcCFPLTwmaZV461YeJNCSmkkG9JdBsvbARFdJyJ/AM1OHQFjr/X5r1iCjd+xjTQSLBLJjMhalJ5jtrWjL6eicmFlaNtTTpBJcWdDpyoIq1d4vlR1JtVtRHZI1nHoPK6hVodnAF/6XUueKaNSDMTMA0jM3QZbzR6iVwp7GvYgqPOTiac6Yin0EEPDos+eTYTmL6+tA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kF1yTn/Xjg8gdLhRnaCvvGS3Os8e63gaMpf96ZTppr7jMsOwo0b0KJSjYNBojVN0Rng6kjs/280IIENl98gnuAPWkGkE3iytZT03PnLSrbAdWFFNRjmweyCybNTLcLwMJPagfYsyFsecaXtYGCqeJa1ejkvW0i+fA7rUQ1ZoBdOGZBLIfX1VpQVOG5feZShnRhG3Dpaf626eiSYK8fJ+vUsFthuqWPnSql+Z+CpJUlotfalbX/ZHJlQyDeycQ1ZcTVRGYi0pRGNjKonhzP/qqOZqcBI3v/TvRuoRaeKFNYnOTYZrjJCyiMcy+D2IGDieOROR/QQfM7oEp5q7g2F3mA==
  • Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Fri, 30 Jul 2021 10:12:58 +0000
  • Ironport-hdrordr: A9a23:fS9yKK/3LJt9MtFLnmBuk+FYdb1zdoMgy1knxilNoENuHPBwxv rAoB1E73PJYVYqOE3Jmbi7Sc29qADnhOBICO4qTMiftWjdyReVxeRZjLcKrAeQYBEWmtQts5 uINpIOdeEYbmIK/voSgjPIa+rIqePvmMvD6Ja8vhUdOD2CKZsQiDuRYjzrYnGeLzM2fKbReq Dsg/av6wDQA0j+Oa+Adwg4tqX41pP2vaOjRSRDKw8s6QGIgz/twLnmEyKA1hNbdz9U278t/U XMjgS8v8yYwrGG4y6Z81WWw4VdmdPnxNcGLMuQivINIjGprgqzfoxuV5CLoThwiuCy71QBls XKvn4bToVOwkKUWlvwjQrm2gHm3jprw3j+yWWAiX+mmsD9TCJSMbsNuatpNj/ir2YwttB116 xGm0iDsYBMMB/GlCPho/DVShBDjCOP0D8fuN9Wq0YafZoVabdXo4Ba1lhSCo08ECXz751iOP VyDfvb+O1dfTqhHjLkV1FUsZuRt0kIb1G7qhBogL3N79EWpgE786Ig/r1aop9an6hNE6Wtjo //Q9ZVfLIndL5dUUsyPpZbfSMbYla9CC4kC1jiVmgPIpt3cE4lm6SHlInd29vaDqDg7KFC1K gpA2ko+lLbRSrVeIWzNdtwg0rwfFk=
  • Ironport-sdr: F/y1hQ3cvlFqfBbGo4Jcp5+dfy2GTEnGLDBSpKDmFJJJ8vu3N6d9Yvn6Px1G7BQIwSvc4ZSGw6 D9zFD6mCS1X66BMn7VW+1t98kBAadJLKhLP2udEnU1dYEz/AxrQ+TF9iL/5vO4cseiEHCsIHEd YfaDlPvcFh/PqZ0mp3lZ0gc3NqxhLe9KSVy+SzZm5AorrMKJu+b0DQzbOukex+0B3Xmq6w7m6l cZAhZcB6KlEDtm5GfLjbbfQskHS5oAC17GOwdyOQ+X5GUkyUvyEJCzn0slvZLnpB6IFbUDc2NO a8bP4cg6itcS47TYOVOF14DX
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 27/07/2021 19:47, Jane Malalane wrote:
> diff --git a/xen/lib/strcmp.c b/xen/lib/strcmp.c
> index 465f1c4191..f85c1e8741 100644
> --- a/xen/lib/strcmp.c
> +++ b/xen/lib/strcmp.c
> @@ -11,14 +11,16 @@
>   */
>  int (strcmp)(const char *cs, const char *ct)
>  {
> -     register signed char __res;
> +     unsigned char *csu = (unsigned char *)cs;
> +     unsigned char *ctu = (unsigned char *)ct;

So there was actually one final thing, but it is holiday season, hence
the lack of replies from others.

We should not be casting away const-ness on the pointers, because that
is undefined behaviour and compilers are starting to warn about it. 
Therefore, we want something like:

const unsigned char *csu = (const unsigned char *)cs;

~Andrew




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.