[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 0/5] PCI: Drop duplicated tracking of a pci_dev's bound driver
 
- To: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
 
- From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
 
- Date: Fri, 30 Jul 2021 07:14:55 +0200
 
- Cc: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>,	Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>, kernel@xxxxxxxxxxxxxx,	linux-pci@xxxxxxxxxxxxxxx, Michael Ellerman <mpe@xxxxxxxxxxxxxx>,	Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>,	Paul Mackerras <paulus@xxxxxxxxx>,	Russell Currey <ruscur@xxxxxxxxxx>,	Oliver O'Halloran <oohall@xxxxxxxxx>,	Peter Zijlstra <peterz@xxxxxxxxxxxxx>,	Ingo Molnar <mingo@xxxxxxxxxx>,	Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>,	Mark Rutland <mark.rutland@xxxxxxx>,	Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>,	Jiri Olsa <jolsa@xxxxxxxxxx>, Namhyung Kim <namhyung@xxxxxxxxxx>,	Thomas Gleixner <tglx@xxxxxxxxxxxxx>,	Borislav Petkov <bp@xxxxxxxxx>, x86@xxxxxxxxxx,	"H. Peter Anvin" <hpa@xxxxxxxxx>,	Rafał Miłecki <zajec5@xxxxxxxxx>,	Zhou Wang <wangzhou1@xxxxxxxxxxxxx>,	Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>,	"David S. Miller" <davem@xxxxxxxxxxxxx>,	Giovanni Cabiddu <giovanni.cabiddu@xxxxxxxxx>,	Sathya Prakash <sathya.prakash@xxxxxxxxxxxx>,	Sreekanth Reddy <sreekanth.reddy@xxxxxxxxxxxx>,	Suganath Prabu Subramani <suganath-prabu.subramani@xxxxxxxxxxxx>,	Frederic Barrat <fbarrat@xxxxxxxxxxxxx>,	Andrew Donnellan <ajd@xxxxxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>,	Yisen Zhuang <yisen.zhuang@xxxxxxxxxx>,	Salil Mehta <salil.mehta@xxxxxxxxxx>,	Jakub Kicinski <kuba@xxxxxxxxxx>,	Vadym Kochan <vkochan@xxxxxxxxxxx>,	Taras Chornyi <tchornyi@xxxxxxxxxxx>, Jiri Pirko <jiri@xxxxxxxxxx>,	Ido Schimmel <idosch@xxxxxxxxxx>,	Simon Horman <simon.horman@xxxxxxxxxxxx>,	Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>,	Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>,	Juergen Gross <jgross@xxxxxxxx>,	Stefano Stabellini <sstabellini@xxxxxxxxxx>,	Michael Buesch <m@xxxxxxx>, Mathias Nyman <mathias.nyman@xxxxxxxxx>,	Fiona Trahe <fiona.trahe@xxxxxxxxx>,	Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>,	Wojciech Ziemba <wojciech.ziemba@xxxxxxxxx>,	Alexander Duyck <alexanderduyck@xxxxxx>,	linuxppc-dev@xxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx,	linux-perf-users@xxxxxxxxxxxxxxx, linux-wireless@xxxxxxxxxxxxxxx,	linux-crypto@xxxxxxxxxxxxxxx, qat-linux@xxxxxxxxx,	MPT-FusionLinux.pdl@xxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx,	netdev@xxxxxxxxxxxxxxx, oss-drivers@xxxxxxxxxxxx,	xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-usb@xxxxxxxxxxxxxxx
 
- Delivery-date: Fri, 30 Jul 2021 05:15:16 +0000
 
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
 
 
 
On Thu, Jul 29, 2021 at 10:37:35PM +0200, Uwe Kleine-König wrote:
> Hello,
> 
> struct pci_dev tracks the bound pci driver twice. This series is about
> removing this duplication.
> 
> The first two patches are just cleanups. The third patch introduces a
> wrapper that abstracts access to struct pci_dev->driver. In the next
> patch (hopefully) all users are converted to use the new wrapper and
> finally the fifth patch removes the duplication.
> 
> Note this series is only build tested (allmodconfig on several
> architectures).
> 
> I'm open to restructure this series if this simplifies things. E.g. the
> use of the new wrapper in drivers/pci could be squashed into the patch
> introducing the wrapper. Patch 4 could be split by maintainer tree or
> squashed into patch 3 completely.
> 
> Best regards
> Uwe
> 
> Uwe Kleine-König (5):
>   PCI: Simplify pci_device_remove()
>   PCI: Drop useless check from pci_device_probe()
>   PCI: Provide wrapper to access a pci_dev's bound driver
>   PCI: Adapt all code locations to not use struct pci_dev::driver
>     directly
>   PCI: Drop duplicated tracking of a pci_dev's bound driver
Other than my objection to patch 5/5 lack of changelog, looks sane to
me:
Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
 
 
    
     |